Test-only tech-debt cleanup: Make TestCtx use stdlib testing.Context() instead of a DIY version
#7669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… function very similarly - just prior to test Cleanup() the test context is cancelled)
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the TestCtx function to leverage Go's stdlib testing.Context() method instead of a custom implementation using context.WithCancel(). This modernizes the code to use standard library functionality introduced in Go 1.24.
Key changes:
- Replaced manual context creation and cancellation with
testing.TB.Context() - Removed explicit cleanup registration since stdlib handles cancellation automatically
- Improved cancellation timing to occur before test cleanup rather than during it
torcolvin
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functions very similarly to the existing DIY version we had written prior to 1.24 but uses stdlib functionality now available.
The only difference is potentially the order of cancellation. Previously it was stacked in
Cleanup()in the orderTestCtxwas called, now the stdlib version always cancels prior to running test cleanup. This is better and more predictable behavior anyway, but wasn't something we were previously capable of controlling.Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/3243/