Skip to content

Further fix for branch sync trickle #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2025

Conversation

MetRonnie
Copy link
Member

Description

Another follow-up to #112

Should fix this failure: https://github.com/cylc/cylc-uiserver/actions/runs/16767615862/job/47475866469

Checklist

  • I have read the contributing instructions in README.md and have opened this against the correct branch & milestone

@MetRonnie MetRonnie self-assigned this Aug 6, 2025
@MetRonnie MetRonnie added the bug Something isn't working label Aug 6, 2025
# default to the HEAD branch (typically either master or main)
base_branch=$(gh repo view --json defaultBranchRef -q .defaultBranchRef.name)
base_branch="$(gh repo view --json defaultBranchRef -q .defaultBranchRef.name)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, this worked with the pure git command, if gh repo view returning results with spaces?

Copy link
Member Author

@MetRonnie MetRonnie Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(That was just a tidy commit, ingrained shellcheck nitpicking, shouldn't matter really)

@oliver-sanders oliver-sanders merged commit 2978d09 into cylc:v1 Aug 6, 2025
7 checks passed
@MetRonnie MetRonnie deleted the branch-sync-fix branch August 6, 2025 13:22
@MetRonnie MetRonnie mentioned this pull request Aug 7, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants