Skip to content

Implements DynSignatureAlgorithmIdentifier trait for ed25519 #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

juliusl
Copy link
Contributor

@juliusl juliusl commented Oct 3, 2024

  • Implements DynSignatureAlgorithmIdentifier trait for SigningKey/VerifyingKey from ed25519-dalek

Addresses #707

@juliusl juliusl changed the title Adds x509-cert support for ed25519 Implements DynSignatureAlgorithmIdentifier trait for ed25519 Oct 3, 2024
@juliusl juliusl force-pushed the pr/impl-spki-algo-identifier-trait branch from e0fc46c to a1155b6 Compare October 3, 2024 20:00
@rozbb
Copy link
Contributor

rozbb commented Oct 5, 2024

Thank you! It looks like CI fails because you use som alloc features. Feel free to copy the gate used elsewhere in signing.rs:

#[cfg(all(feature = "alloc", feature = "pkcs8"))]

@tarcieri tarcieri merged commit 43a16f0 into dalek-cryptography:main Oct 8, 2024
14 checks passed
baloo added a commit to baloo/curve25519-dalek that referenced this pull request Jun 4, 2025
…c counterpart

This allows to use ed25519 to create certificates for example

This partially reverts dalek-cryptography#712
baloo added a commit to baloo/curve25519-dalek that referenced this pull request Jul 7, 2025
…c counterpart

This allows to use ed25519 to create certificates for example

This partially reverts dalek-cryptography#712
tarcieri pushed a commit that referenced this pull request Jul 7, 2025
…c counterpart (#779)

This allows to use ed25519 to create certificates for example

This partially reverts #712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants