Friendlier per-owner subtasks #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeannamatthews
changed the title
nshuba
approved these changes
Aug 12, 2025
|
@nshuba in the postmortem you mentioned wanting to have another look at things checked in since you reviewed. Let me know if there is anything else you'd like me to do on this before merging. |
nshuba
reviewed
Aug 16, 2025
Comment on lines
+52
to
+54
| pixelPhrase += ` | ||
|
|
||
| New to these reports ? See <a href="${INSTRUCTIONS_TASK_URL}">View task</a>`; |
There was a problem hiding this comment.
Would this not work with Asana APIs?
Suggested change
| pixelPhrase += ` | |
| New to these reports ? See <a href="${INSTRUCTIONS_TASK_URL}">View task</a>`; | |
| pixelPhrase += `\nNew to these reports ? See <a href="${INSTRUCTIONS_TASK_URL}">View task</a>`; |
|
|
||
| // Write thisOwnersPixelsWithErrors to a temporary file | ||
| const tempFilePath = path.join(dirPath, `pixel_errors_${owner}.json`); | ||
| fs.writeFileSync(tempFilePath, JSON.stringify(ownersPixelData, null, 2)); |
There was a problem hiding this comment.
Minor: our prettier standard is 4 spaces
| if (pixel.owners) { | ||
| pixel.owners.forEach((owner) => ownersSet.add(owner)); | ||
| pixel.owners.forEach((owner) => { |
There was a problem hiding this comment.
Won't this assign the same pixel more than once if there are multiple owners? I'd just assign to the first owner. Otherwise we risk 2+ people spending their time fixing the same thing
Merged
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.