Skip to content

manylinux support #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2024
Merged

manylinux support #199

merged 1 commit into from
Aug 12, 2024

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Aug 8, 2024

Thanks you for the awesome project! I was doing some hunting, and noticed that prebuilt wasn't available across all platforms, so I thought I'd take a stab. Given your use of maturin-paction this PR, and this documentation change it appears like adding qemu will provide platform support.

Hopefully this helps, and thanks a tonne for the project!!

@saulshanabrook
Copy link
Member

Thank you for your contribution!

From the PyPi page it looks like there are some manylinux builds available. Do you know after this PR what other platforms you would expect to be built so we can make sure it is working in our next release?

Copy link

codspeed-hq bot commented Aug 8, 2024

CodSpeed Performance Report

Merging #199 will not alter performance

Comparing chayim:ck-armies (af4ca20) with main (0a92570)

Summary

✅ 7 untouched benchmarks

@chayim
Copy link
Contributor Author

chayim commented Aug 12, 2024

I don't know categorically, but the previous link in the description is to a table in the maturin-action itself, where they have a table! Suffice it to say multiple arm, ppc and s390 platforms. This is in addition to the default i686 and x86_64.

@saulshanabrook saulshanabrook merged commit 3b877e4 into egraphs-good:main Aug 12, 2024
9 checks passed
@chayim chayim mentioned this pull request Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants