Require cmake 3.10.2 for consistency #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A more recent version of cmake is already required for other Harmonic dependencies, such as gz-cmake3, so increase the required version here to fix a warning. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
on the gz-plugin2 branch, we have two cmake warnings in the homebrew build: this branch fixes the one reported in #160; only the warning related to gazebosim/gz-cmake#461 remains |
j-rivero
approved these changes
Feb 6, 2025
|
@scpeters do we need a backport for gz-plugin1? See the same warnings you mention in https://build.osrfoundation.org/job/gz_plugin-ci-ign-plugin1-homebrew-amd64/110/cmake/ |
yes we could backport this, though we should rephrase the version number references |
|
https://github.com/Mergifyio backport ign-plugin1 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
A more recent version of cmake is already required for other Harmonic dependencies, such as gz-cmake3, so increase the required version here to fix a warning. Signed-off-by: Steve Peters <scpeters@openrobotics.org> (cherry picked from commit bdcca3c)
8 tasks
scpeters
added a commit
that referenced
this pull request
Feb 10, 2025
A more recent version of cmake is already required for other Fortress dependencies, such as ign-cmake2, so increase the required version here to fix a warning. Signed-off-by: Steve Peters <scpeters@openrobotics.org> (cherry picked from commit bdcca3c) (reworded to refer to Fortress instead of Harmonic)
scpeters
added a commit
that referenced
this pull request
Feb 10, 2025
A more recent version of cmake is already required for other Fortress dependencies, such as ign-cmake2, so increase the required version here to fix a warning. Signed-off-by: Steve Peters <scpeters@openrobotics.org> (cherry picked from commit bdcca3c) (reworded to refer to Fortress instead of Harmonic) Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #160
Summary
A more recent version of cmake is already required for other Harmonic dependencies, such as gz-cmake3, so increase the required version here to fix a warning.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.