-
Notifications
You must be signed in to change notification settings - Fork 65
patches for DLM / LINKIMAGE support #2060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GillesDuvert
wants to merge
18
commits into
gnudatalanguage:master
Choose a base branch
from
GillesDuvert:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… documentation is devoid of useful examples). Reverting to adding system-dependent linker flags by ourselves.
… (linked images compilation details yet to be solved??)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2060 +/- ##
=========================================
Coverage ? 41.39%
=========================================
Files ? 452
Lines ? 113227
Branches ? 22487
=========================================
Hits ? 46865
Misses ? 66362
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…to std::string creates an unnecessary string copy or length calculation. Solve that by directly passing the string.
…nothing, better put the freed pointer to NULL, as free(NULL) is safe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following #2058 , adding IDL_VarGetString and possibly cure a segfault in IDLKwProcessByOffset