feat: use gameservers.lists.maxItems instead of a hardcoded limit

[miai10]

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

The number of items in a list are bounded to the hardcoded value of 1000. During load tests, this value seems too low so a mechanism to configure it was put in place using Helm values. The default is still 1000 to be backwards compatible.

Which issue(s) this PR fixes:

Closes #4192

Special notes for your reviewer:

[miai10]

Using the make gen-install command returns an error because the .Values.agones.crds.gameserver.lists.maxItems value is nil. It is suppose to use the value from the values file. Not sure why is that, still investigating but let me know if somebody has an idea...

The complete error:

`root@2ddf739d200f:/workspaces/agones/build# make gen-install

mkdir -p ~/.kube/
mkdir -p /workspaces/agones/build//.gocache
mkdir -p /workspaces/agones/build//.config/gcloud
mkdir -p ~/.config/helm
mkdir -p ~/.cache/helm
make ensure-image IMAGE_TAG=agones-build:419ba293a7 BUILD_TARGET=build-build-image
make[1]: Entering directory '/workspaces/agones/build'
make[1]: Leaving directory '/workspaces/agones/build'
docker run --rm -v /workspaces/agones/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.config/helm:/root/.config/helm -v ~/.cache/helm:/root/.cache/helm -v /workspaces/agones:/go/src/agones.dev/agones -v /workspaces/agones/build//.gomod:/go/pkg/mod -v /workspaces/agones/build//.gocache:/root/.cache/go-build agones-build:419ba293a7 bash -c
'helm template agones-manual --namespace agones-system /go/src/agones.dev/agones/install/helm/agones
--set agones.controller.generateTLS=false
--set agones.allocator.generateTLS=false
--set agones.allocator.generateClientTLS=false
--set agones.crds.cleanupOnDelete=false
> /go/src/agones.dev/agones/install/yaml/install.yaml'
Error: template: agones/templates/crds/gameserverset.yaml:117:22: executing "agones/templates/crds/gameserverset.yaml" at <include "gameserver.schema" $data>: error calling include: template: agones/templates/crds/_gameserverspecschema.yaml:194:33: executing "gameserver.schema" at <.Values.agones.crds.gameserver.lists.maxItems>: nil pointer evaluating interface {}.agones`

[miai10]

Using the make gen-install command returns an error because the .Values.agones.crds.gameserver.lists.maxItems value is nil. It is suppose to use the value from the values file. Not sure why is that, still investigating but let me know if somebody has an idea...

The complete error:

`root@2ddf739d200f:/workspaces/agones/build# make gen-install

mkdir -p ~/.kube/ mkdir -p /workspaces/agones/build//.gocache mkdir -p /workspaces/agones/build//.config/gcloud mkdir -p ~/.config/helm mkdir -p ~/.cache/helm make ensure-image IMAGE_TAG=agones-build:419ba293a7 BUILD_TARGET=build-build-image make[1]: Entering directory '/workspaces/agones/build' make[1]: Leaving directory '/workspaces/agones/build' docker run --rm -v /workspaces/agones/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.config/helm:/root/.config/helm -v ~/.cache/helm:/root/.cache/helm -v /workspaces/agones:/go/src/agones.dev/agones -v /workspaces/agones/build//.gomod:/go/pkg/mod -v /workspaces/agones/build//.gocache:/root/.cache/go-build agones-build:419ba293a7 bash -c 'helm template agones-manual --namespace agones-system /go/src/agones.dev/agones/install/helm/agones --set agones.controller.generateTLS=false --set agones.allocator.generateTLS=false --set agones.allocator.generateClientTLS=false --set agones.crds.cleanupOnDelete=false > /go/src/agones.dev/agones/install/yaml/install.yaml' Error: template: agones/templates/crds/gameserverset.yaml:117:22: executing "agones/templates/crds/gameserverset.yaml" at <include "gameserver.schema" $data>: error calling include: template: agones/templates/crds/_gameserverspecschema.yaml:194:33: executing "gameserver.schema" at <.Values.agones.crds.gameserver.lists.maxItems>: nil pointer evaluating interface {}.agones`

Thanks, @lacroixthomas for the help to fix this!

[miai10]

This change is not related to my changes but this is how the new install.yaml file got regenerated

[lacroixthomas]

/gcbrun

[agones-bot]

Build Succeeded 🥳

Build Id: 50854079-a8d7-433c-a210-e8119671a0d3

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.52.0-dev-a2341e7
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.52.0-dev-a2341e7
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.52.0-dev-a2341e7-linux
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.52.0-dev-a2341e7
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.52.0-dev-a2341e7
• image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.52.0-dev-a2341e7
• Linux C++ SDK (build): agonessdk-1.52.0-dev-a2341e7-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.52.0-dev-a2341e7.zip

A preview of the website (the last 30 builds are retained):

• https://a2341e7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4246/head:pr_4246 && git checkout pr_4246
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-a2341e7

[miai10]

@markmandel @lacroixthomas : let me know if this needs more work or we should merge it

[markmandel]

I'm back from devcom and Gamescom - I can peek at this shortly!