feat: use gameservers.lists.maxItems instead of a hardcoded limit

install/helm/agones/templates/crds/_gameserverspecschema.yaml

@@ -191,12 +191,12 @@ properties:
               title: Max capacity of the array (can be less than or equal to value of maxItems)
               minimum: 0
               default: 1000
-              maximum: 1000 # must be equal to values.maxItems
+              maximum: {{ .lists.maxItems }} # must be equal to values.maxItems
             values:
               title: set of all the items in the list
               type: array
               x-kubernetes-list-type: set # Requires items in the array to be unique
-              maxItems: 1000 # max possible size of the value array (cannot be updated)
+              maxItems: {{ .lists.maxItems }} # max possible size of the value array (cannot be updated)
               items: # name of the item (player1, session1, room1, etc.)
                 type: string
               default: []

install/helm/agones/templates/crds/_gameserverstatus.yaml

@@ -106,12 +106,12 @@ status:
             type: integer
             minimum: 0
             default: 1000
-            maximum: 1000 # must be equal to values.maxItems
+            maximum: {{ .lists.maxItems }} # must be equal to values.maxItems
           values:
             title: Set of all the items in the list
             type: array
             x-kubernetes-list-type: set # Requires items in the array to be unique
-            maxItems: 1000 # max possible size of the value array (cannot be updated)
+            maxItems: {{ .lists.maxItems }} # max possible size of the value array (cannot be updated)
             items: # name of the item (player1, session1, room1, etc.)
               type: string
             default: []

install/helm/agones/templates/crds/fleet.yaml

@@ -134,7 +134,11 @@ spec:
                           - Ascending
                           - Descending
                 template:
-                  {{- $data := dict "metadata" true "podPreserveUnknownFields" .Values.gameservers.podPreserveUnknownFields }}
+                  {{- $data := dict 
+                    "metadata" true 
+                    "podPreserveUnknownFields" .Values.gameservers.podPreserveUnknownFields
+                    "lists" .Values.agones.crds.gameserver.lists
+                  }}
                   {{- include "gameserver.schema" $data | indent 17 }}
             status:
               description: 'FleetStatus is the status of a Fleet. More info:

install/helm/agones/templates/crds/gameserver.yaml

@@ -55,7 +55,10 @@ spec:
           type: date
       schema:
         openAPIV3Schema:
-          {{- $data := dict "podPreserveUnknownFields" .Values.gameservers.podPreserveUnknownFields }}
+          {{- $data := dict 
+            "podPreserveUnknownFields" .Values.gameservers.podPreserveUnknownFields 
+            "lists" .Values.agones.crds.gameserver.lists
+          }}
           {{- include "gameserver.schema" $data | indent 9 }}{{- /* include the schema then status, as it's easier to align */ -}}
           {{- include "gameserver.status" $data | indent 11 }}
       subresources:

install/helm/agones/templates/crds/gameserverset.yaml

@@ -113,7 +113,11 @@ spec:
                           - Ascending
                           - Descending
                 template:
-                  {{- $data := dict "metadata" true "podPreserveUnknownFields" .Values.gameservers.podPreserveUnknownFields }}
+                  {{- $data := dict 
+                    "metadata" true 
+                    "podPreserveUnknownFields" .Values.gameservers.podPreserveUnknownFields
+                    "lists" .Values.agones.crds.gameserver.lists
+                  }}
                   {{- include "gameserver.schema" $data | indent 18 }}
             status:
               description: 'GameServerSetStatus is the status of a GameServerSet. More info:

install/helm/agones/values.schema.json

@@ -44,6 +44,19 @@
             "cleanupJobTTL": {
               "type": "integer",
               "minimum": 0
+            },
+            "gameserver": {
+              "type": "object",
+              "properties": {
+                "lists": {
+                  "type": "object",
+                  "properties": {
+                    "maxItems": {
+                      "type": "integer"
+                    }
+                  }
+                }
+              }
             }
           },
           "if": {

install/helm/agones/values.yaml

@@ -33,6 +33,9 @@ agones:
     install: true
     cleanupOnDelete: true
     cleanupJobTTL: 60
+    gameserver:
+      lists:
+        maxItems: 1000
   serviceaccount:
     allocator:
       name: agones-allocator

install/yaml/install.yaml

@@ -1,4 +1,13 @@
 ---
+# Source: agones/templates/priority-class.yaml
+apiVersion: scheduling.k8s.io/v1
+kind: PriorityClass
+metadata:
+  name: agones-system
+value: 1000000
+globalDefault: false
+description: "This priority class should be used for Agones service pods only."
+---
 # Source: agones/templates/controller.yaml
 apiVersion: policy/v1
 kind: PodDisruptionBudget
@@ -19175,15 +19184,6 @@ webhooks:
         operations:
           - CREATE
 ---
-# Source: agones/templates/priority-class.yaml
-apiVersion: scheduling.k8s.io/v1
-kind: PriorityClass
-metadata:
-  name: agones-system
-value: 1000000
-globalDefault: false
-description: "This priority class should be used for Agones service pods only."
----
 # Source: agones/templates/extensions.yaml
 apiVersion: admissionregistration.k8s.io/v1
 kind: ValidatingWebhookConfiguration

site/content/en/docs/Installation/Install Agones/helm.md

@@ -105,11 +105,12 @@ The following tables lists the configurable parameters of the Agones chart and t
 
 ### Custom Resource Definitions
 
-| Parameter                     | Description                                                                                                                                                                                                                         | Default |
-| ----------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------- |
-| `agones.crds.install`         | Install the CRDs with this chart. Useful to disable if you want to subchart (since crd-install hook is broken), so you can copy the CRDs into your own chart.                                                                       | `true`  |
-| `agones.crds.cleanupOnDelete` | Run the pre-delete hook to delete all GameServers and their backing Pods when deleting the helm chart, so that all CRDs can be removed on chart deletion                                                                            | `true`  |
-| `agones.crds.cleanupJobTTL`   | The number of seconds for Kubernetes to delete the associated Job and Pods of the pre-delete hook after it completes, regardless if the Job is successful or not. Set to `0` to disable cleaning up the Job or the associated Pods. | `60`    |
+| Parameter                               | Description                                                                                                                                                                                                                         | Default |
+| --------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------- |
+| `agones.crds.install`                   | Install the CRDs with this chart. Useful to disable if you want to subchart (since crd-install hook is broken), so you can copy the CRDs into your own chart.                                                                       | `true`  |
+| `agones.crds.cleanupOnDelete`           | Run the pre-delete hook to delete all GameServers and their backing Pods when deleting the helm chart, so that all CRDs can be removed on chart deletion                                                                            | `true`  |
+| `agones.crds.cleanupJobTTL`             | The number of seconds for Kubernetes to delete the associated Job and Pods of the pre-delete hook after it completes, regardless if the Job is successful or not. Set to `0` to disable cleaning up the Job or the associated Pods. | `60`    |
+| `agones.crds.gameserver.lists.maxItems` | The maximum number of items that can be specified for a list.                                                                                                                                                                       | `1000`  |
 
 ### Metrics