Cat dev score parsing #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
n-gilbertson
commented
May 2, 2025
n-gilbertson
commented
- Cleaned up style formatting throughout
- Added in combined score for both types of categories (max score if non-ordinal; 'averaged' if ordinal)
- Added summary indicator whether category type is ordinal or non-ordinal based on cat_order settings
- Created new function for calculating UIs, logBPRF, and score
- Created new function for getting star rating from score
- Refactored get_pair_info and get_linear_model_summary using the two new functions
…air_info and get_linear_model_summary
zhengp0
reviewed
May 5, 2025
zhengp0
reviewed
May 5, 2025
zhengp0
reviewed
May 5, 2025
zhengp0
approved these changes
May 5, 2025
There was a problem hiding this comment.
Thanks @n-gilbertson! I left some minor comments, but I think this is good to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.