Skip to content

Cat dev score parsing #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 8, 2025
Merged

Cat dev score parsing #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
adace05
minor style cleaning
n-gilbertson May 2, 2025
04126c4
new functions for score and star rating calculation; refactored get_p…
n-gilbertson May 2, 2025
32724f8
shifted score to star rating function to utils, minor type hinting ch…
n-gilbertson May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/bopforge/categorical_pipeline/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def fit_signal_model(result_folder: Path) -> None:
all_settings = dataif.load_result("settings.yaml")
summary = dataif.load_result("summary.yaml")

signal_model = functions.get_signal_model(all_settings, df, summary)
signal_model = functions.get_signal_model(df, all_settings, summary)
signal_model.fit_model(outer_step_size=200, outer_max_iter=100)

df = functions.add_cols(df, signal_model)
Expand Down Expand Up @@ -110,7 +110,7 @@ def select_bias_covs(result_folder: Path) -> None:
cov_finder_linear_model = dataif.load_result("signal_model.pkl")

cov_finder = functions.get_cov_finder(
all_settings, settings, cov_finder_linear_model, df
df, all_settings, settings, cov_finder_linear_model
)
cov_finder.select_covs(verbose=True)

Expand Down Expand Up @@ -158,7 +158,7 @@ def fit_linear_model(result_folder: Path) -> None:
)

summary = functions.get_linear_model_summary(
all_settings, settings, summary, df, cat_coefs, pair_coefs
df, all_settings, settings, summary, cat_coefs, pair_coefs
)

df_cleaned = df.loc[:, ~df.columns.str.startswith("interacted_")]
Expand All @@ -168,12 +168,11 @@ def fit_linear_model(result_folder: Path) -> None:
)

fig = functions.plot_linear_model(
df,
name,
summary,
df,
cat_coefs,
pair_coefs,
show_ref=all_settings["figure"]["show_ref"],
)

dataif.dump_result(linear_model, "linear_model.pkl")
Expand Down
Loading