Skip to content

show peer stats after sync #4086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 21, 2025
Merged

Conversation

ricomateo
Copy link
Contributor

@ricomateo ricomateo commented Aug 19, 2025

Motivation
Currently, the peer stats are only logged during the sync phase.
However we also want to see the peer stats after the node has finished syncing.

Description
This PR updates the periodically_show_peer_stats function to improve peer stats logs:

  • During sync: peer stats are logged together with the sync progress.
  • After sync: peer stats continue to be logged independently.

Copy link

github-actions bot commented Aug 19, 2025

Lines of code report

Total lines added: 45
Total lines removed: 0
Total lines changed: 45

Detailed view
+-----------------------------------------+-------+------+
| File                                    | Lines | Diff |
+-----------------------------------------+-------+------+
| ethrex/cmd/ethrex/initializers.rs       | 376   | +3   |
+-----------------------------------------+-------+------+
| ethrex/crates/networking/p2p/network.rs | 417   | +42  |
+-----------------------------------------+-------+------+

@ricomateo ricomateo marked this pull request as ready for review August 19, 2025 20:55
@ricomateo ricomateo requested a review from a team as a code owner August 19, 2025 20:55
@ricomateo ricomateo changed the title show peer data after sync show peer stats after sync Aug 19, 2025
@jrchatruc jrchatruc merged commit 14bde42 into snap_sync Aug 21, 2025
14 of 18 checks passed
@jrchatruc jrchatruc deleted the snap_sync_show_peer_data_after_sync branch August 21, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants