Skip to content

show peer stats after sync #4086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions cmd/ethrex/initializers.rs
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ pub async fn init_network(
signer,
peer_table.clone(),
store,
blockchain,
blockchain.clone(),
get_client_version(),
based_context,
);
Expand All @@ -200,7 +200,10 @@ pub async fn init_network(
.await
.expect("Network starts");

tracker.spawn(ethrex_p2p::periodically_show_peer_stats());
tracker.spawn(ethrex_p2p::periodically_show_peer_stats(
blockchain,
peer_table.peers.clone(),
));
}

#[cfg(feature = "dev")]
Expand Down
52 changes: 49 additions & 3 deletions crates/networking/p2p/network.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,25 @@ use crate::{
discv4::{
server::{DiscoveryServer, DiscoveryServerError},
side_car::{DiscoverySideCar, DiscoverySideCarError},
}, kademlia::Kademlia, metrics::METRICS, rlpx::{
},
kademlia::{Kademlia, PeerData},
metrics::METRICS,
rlpx::{
connection::server::{RLPxConnBroadcastSender, RLPxConnection},
initiator::{RLPxInitiator, RLPxInitiatorError},
l2::l2_connection::P2PBasedContext,
message::Message,
}, tx_broadcaster::{TxBroadcaster, TxBroadcasterError}, types::{Node, NodeRecord}
p2p::SUPPORTED_SNAP_CAPABILITIES,
},
tx_broadcaster::{TxBroadcaster, TxBroadcasterError},
types::{Node, NodeRecord},
};
use ethrex_blockchain::Blockchain;
use ethrex_common::H256;
use ethrex_storage::Store;
use secp256k1::SecretKey;
use std::{
collections::BTreeMap,
io,
net::SocketAddr,
sync::Arc,
Expand Down Expand Up @@ -170,9 +178,20 @@ fn listener(tcp_addr: SocketAddr) -> Result<TcpListener, io::Error> {
tcp_socket.listen(50)
}

pub async fn periodically_show_peer_stats() {
pub async fn periodically_show_peer_stats(
blockchain: Arc<Blockchain>,
peers: Arc<Mutex<BTreeMap<H256, PeerData>>>,
) {
periodically_show_peer_stats_during_syncing(blockchain).await;
periodically_show_peer_stats_after_sync(peers).await;
}

pub async fn periodically_show_peer_stats_during_syncing(blockchain: Arc<Blockchain>) {
let start = std::time::Instant::now();
loop {
if blockchain.is_synced() {
return;
}
let metrics_enabled = *METRICS.enabled.lock().await;
// Show the metrics only when these are enabled
if !metrics_enabled {
Expand Down Expand Up @@ -419,6 +438,33 @@ bytecodes progress: {bytecodes_download_progress} (total: {bytecodes_to_download
}
}

/// Shows the amount of connected peers, active peers, and peers suitable for snap sync on a set interval
pub async fn periodically_show_peer_stats_after_sync(peers: Arc<Mutex<BTreeMap<H256, PeerData>>>) {
const INTERVAL_DURATION: tokio::time::Duration = tokio::time::Duration::from_secs(60);
let mut interval = tokio::time::interval(INTERVAL_DURATION);
loop {
// clone peers to keep the lock short
let peers: Vec<PeerData> = peers.lock().await.values().cloned().collect();
let active_peers = peers
.iter()
.filter(|peer| -> bool { peer.channels.as_ref().is_some() })
.count();
let snap_active_peers = peers
.iter()
.filter(|peer| -> bool {
peer.channels.as_ref().is_some()
&& SUPPORTED_SNAP_CAPABILITIES
.iter()
.any(|cap| peer.supported_capabilities.contains(cap))
})
.count();
info!(
"Snap Peers: {snap_active_peers} / Total Peers: {active_peers}"
);
interval.tick().await;
}
}

fn format_duration(duration: Duration) -> String {
let total_seconds = duration.as_secs();
let hours = total_seconds / 3600;
Expand Down
Loading