fix(l1): use proper docker image to spin up localnets. #4131
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes docker image configuration for local network testing by switching from stable to locally-built ethrex images and simplifies the Makefile structure. The changes ensure that local development uses the current codebase rather than a stable release and consolidate multiple localnet commands into a single configurable target.
- Corrected docker image tag from
ethrex:unstabletoethrexand fixed parameter format in network configuration - Consolidated multiple localnet Makefile targets into a single configurable command
- Fixed parameter passing format for
el_extra_paramsfrom space-separated to equals-separated syntax
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| fixtures/network/network_params_client_comparision.yaml | Fixed parameter format for ethrex EVM configuration |
| Makefile | Updated docker image tag and consolidated localnet commands into single configurable target |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| kurtosis run --enclave $(ENCLAVE) ethereum-package --args-file fixtures/network/network_params.yaml | ||
| docker logs -f $$(docker ps -q --filter name=snooper-engine-3-lighthouse-ethrex) | ||
|
|
||
| localnet-client-comparision: stop-localnet-silent build-image checkout-ethereum-package ## 🌐 Start local network |
There was a problem hiding this comment.
This removes a lot of unrelated makefile targets. Is that ok?
There was a problem hiding this comment.
yes, I don't think we need one target per network
| docker build -t ethrex:unstable . | ||
| docker build -t ethrex . |
There was a problem hiding this comment.
There are some places in CI and makefile where we retag this, I think. We should clean up those
There was a problem hiding this comment.
yes, its being worked on here: #4120
In general we shouldn't use make targets on the CI IMO
Motivation
We were using the stable ethrex docker images instead of the one build locally
Description
el_extra_params