Skip to content

fix(l1): use proper docker image to spin up localnets. #4131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2025
Merged

fix(l1): use proper docker image to spin up localnets. #4131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 3 additions & 26 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ clean: clean-vectors ## 🧹 Remove build artifacts

STAMP_FILE := .docker_build_stamp
$(STAMP_FILE): $(shell find crates cmd -type f -name '*.rs') Cargo.toml Dockerfile
docker build -t ethrex:unstable .
docker build -t ethrex .
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some places in CI and makefile where we retag this, I think. We should clean up those

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, its being worked on here: #4120

In general we shouldn't use make targets on the CI IMO

touch $(STAMP_FILE)

build-image: $(STAMP_FILE) ## 🐳 Build the Docker image
Expand Down Expand Up @@ -62,34 +62,11 @@ checkout-ethereum-package: ## 📦 Checkout specific Ethereum package revision
fi

ENCLAVE ?= lambdanet
LOCALNET_CONFIG_FILE ?= ./fixtures/network/network_params.yaml

localnet: stop-localnet-silent build-image checkout-ethereum-package ## 🌐 Start local network
kurtosis run --enclave $(ENCLAVE) ethereum-package --args-file fixtures/network/network_params.yaml
docker logs -f $$(docker ps -q --filter ancestor=ethrex)

localnet-snooper: stop-localnet-silent build-image checkout-ethereum-package ## 🌐 Start local network and output the JSON-RPC requests ethrex exchanges with the consensus client
kurtosis run --enclave $(ENCLAVE) ethereum-package --args-file fixtures/network/network_params.yaml
docker logs -f $$(docker ps -q --filter name=snooper-engine-3-lighthouse-ethrex)

localnet-client-comparision: stop-localnet-silent build-image checkout-ethereum-package ## 🌐 Start local network
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes a lot of unrelated makefile targets. Is that ok?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I don't think we need one target per network

cp metrics/provisioning/grafana/dashboards/common_dashboards/ethrex_l1_perf.json ethereum-package/src/grafana/ethrex_l1_perf.json
kurtosis run --enclave $(ENCLAVE) ethereum-package --args-file fixtures/network/network_params_client_comparision.yaml
docker logs -f $$(docker ps -q -n 1 --filter ancestor=ethrex)

localnet-assertoor-blob: stop-localnet-silent build-image checkout-ethereum-package ## 🌐 Start local network with assertoor test
kurtosis run --enclave $(ENCLAVE) ethereum-package --args-file .github/config/assertoor/network_params_blob.yaml
docker logs -f $$(docker ps -q --filter ancestor=ethrex)

localnet-assertoor-ethrex-only: stop-localnet-silent build-image checkout-ethereum-package ## 🌐 Start local network with assertoor test
kurtosis run --enclave $(ENCLAVE) ethereum-package --args-file fixtures/network/network_params_ethrex_only.yaml
docker logs -f $$(docker ps -q -n 1 --filter ancestor=ethrex)

localnet-assertoor-different-cl: stop-localnet-silent build-image checkout-ethereum-package ## 🌐 Start local network with assertoor test
kurtosis run --enclave $(ENCLAVE) ethereum-package --args-file .github/config/assertoor/network_params_ethrex_multiple_cl.yaml
docker logs -f $$(docker ps -q -n 1 --filter ancestor=ethrex)

localnet-assertoor-tx: stop-localnet-silent build-image checkout-ethereum-package ## 🌐 Start local network with assertoor test
kurtosis run --enclave $(ENCLAVE) ethereum-package --args-file .github/config/assertoor/network_params_tx.yaml
kurtosis run --enclave $(ENCLAVE) ethereum-package --args-file $(LOCALNET_CONFIG_FILE)
docker logs -f $$(docker ps -q --filter ancestor=ethrex)

stop-localnet: ## 🛑 Stop local network
Expand Down
2 changes: 1 addition & 1 deletion fixtures/network/network_params_client_comparision.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ participants:
count: 1
- el_type: ethrex
el_image: ethrex:latest
el_extra_params: ["--evm revm"]
el_extra_params: ["--evm=revm"]
cl_type: lighthouse
cl_image: sigp/lighthouse:v7.0.1
el_extra_labels: { "evm": "revm" }
Expand Down
Loading