remove libmodplug support. #673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(CC @madebr for cmake side, just in case) |
madebr
approved these changes
Mar 9, 2025
|
This seems fine to me. I'll let @icculus merge when he's ready, I don't know what local changes he has at the moment. We should leave SDL2 alone. |
|
OK, I went ahead and removed the obsolete enum values MUS_MODPLUG_UNUSED and MUS_MP3_MAD_UNUSED. @icculus: merge? |
Yes, go ahead and merge. |
Done |
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Apr 26, 2025
libmodplug support has been removed in master branch libsdl-org/SDL_mixer#673 Remove the option as we still provide libxmp to handle .mod Signed-off-by: Markus Volk <f_l_k@t-online.de> Signed-off-by: Khem Raj <raj.khem@gmail.com>
daregit
pushed a commit
to daregit/yocto-combined
that referenced
this pull request
Apr 30, 2025
…ONFIG libmodplug support has been removed in master branch libsdl-org/SDL_mixer#673 Remove the option as we still provide libxmp to handle .mod Signed-off-by: Markus Volk <f_l_kt-online.de> Signed-off-by: Khem Raj <raj.khemgmail.com>
daregit
pushed a commit
to daregit/yocto-combined
that referenced
this pull request
May 5, 2025
…ONFIG libmodplug support has been removed in master branch libsdl-org/SDL_mixer#673 Remove the option as we still provide libxmp to handle .mod Signed-off-by: Markus Volk <f_l_kt-online.de> Signed-off-by: Khem Raj <raj.khemgmail.com>
daregit
pushed a commit
to daregit/yocto-combined
that referenced
this pull request
May 6, 2025
…ONFIG libmodplug support has been removed in master branch libsdl-org/SDL_mixer#673 Remove the option as we still provide libxmp to handle .mod Signed-off-by: Markus Volk <f_l_kt-online.de> Signed-off-by: Khem Raj <raj.khemgmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #672
@icculus, @slouken: What to do with
MUS_MODPLUG_UNUSEDenumerated valuein the public interface? Just remove it? (We have no SDL3_mixer releases
anyway. Same for the
MUS_MP3_MAD_UNUSEDthing.)P.S.: Should I do the same in SDL2 branch, or keep it as is?