upgrade vendored libmpg123 to 1.33.2

[sezero]

If this is good, should I cherry-pick to SDL2 (and even to release-2.8.x) ?

[madebr]

Keeping these up to date will save us from bitrot in the future :)

Deflecting question about SDL2 towards slouken

[sezero]

I did a very minor touch to Xcode project, but the configs and the project file are way outdated: If this gets merged, they'll need updating.

[smoogipoo]

Hi, not sure if this is the place to mention this, but ever since the update to SDL3_mixer our builds have been failing with:

"D:\a\SDL3-CS\SDL3-CS\External\SDL_mixer\build\SDL3_mixer-shared.vcxproj" (default target) (3) ->
(ClCompile target) -> 
  D:\a\SDL3-CS\SDL3-CS\External\SDL_mixer\build\external\libmpg123-build\ports\cmake\src\libmpg123\mpg123.h(12,10): error C1083: Cannot open include file: 'fmt123.h': No such file or directory [D:\a\SDL3-CS\SDL3-CS\External\SDL_mixer\build\SDL3_mixer-shared.vcxproj]

Using:

cmake -B build -DCMAKE_BUILD_TYPE=Release -DSDL_SHARED=ON -DSDL_STATIC=OFF -DSDLMIXER_DEPS_SHARED=OFF -DSDLMIXER_VENDORED=ON

Thought I'd mention this here since the lib is being upgraded, but as far as I can tell this PR doesn't appear to fix this (and obviously you are all able to build it correctly). What are we doing wrong here? Would like to not have to disable mpg123 if possible.

Same result on all platforms, macOS included -- I noticed this PR specifically touches the Xcode project.

Ref: ppy/SDL3-CS#237

[madebr]

Hi, not sure if this is the place to mention this, but ever since the update to SDL3_mixer our builds have been failing with:

"D:\a\SDL3-CS\SDL3-CS\External\SDL_mixer\build\SDL3_mixer-shared.vcxproj" (default target) (3) ->
(ClCompile target) -> 
  D:\a\SDL3-CS\SDL3-CS\External\SDL_mixer\build\external\libmpg123-build\ports\cmake\src\libmpg123\mpg123.h(12,10): error C1083: Cannot open include file: 'fmt123.h': No such file or directory [D:\a\SDL3-CS\SDL3-CS\External\SDL_mixer\build\SDL3_mixer-shared.vcxproj]

This looks like a bug in the upstream mpg123 cmake script.
https://github.com/libsdl-org/mpg123/blob/b4abae51e1f59e85cf0c0f9ca80ad58d777cfb28/ports/cmake/src/libmpg123/CMakeLists.txt#L248
Try adding"$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../../../../src/include>" to this list.

[smoogipoo]

Yeah, that looks to fix it! cc/ @sobukus

[slouken]

SDL2 should get any security updates but we're not currently planning additional releases from the SDL2 branch. If this is a critical update, I'd merge, but otherwise leave it if it's not important.

[sezero]

SDL2 should get any security updates but we're not currently planning additional releases from the SDL2 branch. If this is a critical update, I'd merge, but otherwise leave it if it's not important.

OK, leaving SDL2 as is

[slouken]

The SDL_mixer Xcode project doesn't currently build mpg123 or FLAC, relying on the built-in loaders. Maybe we can just remove those Xcode projects?

[sezero]

Sure, your call

[slouken]

I went ahead and just updated it.

[sezero]

I went ahead and just updated it.

The config.h files are very outdated - they are from mpg123-1.29.3 and very much in need of updating

[slouken]

I went ahead and just updated it.

The config.h files are very outdated - they are from mpg123-1.29.3 and very much in need of updating

Fixed.