Skip to content

Fix build by disabling mpg123 and libflac #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 15, 2025
Merged

Conversation

smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Aug 13, 2025

Resolves #237

Both of these were turned on (previously disabled) as SDL_mixer moved to SDL3_mixer. They seem to suffer from upstream build issues, and there are fallbacks (dr_mp3 and dr_flac) in place.

Have also updated submodules/bindings, pulling in a few important fixes, such as:

Build: https://github.com/smoogipoo/SDL3-CS/actions/runs/16944726382

Issues:

@smoogipoo smoogipoo marked this pull request as ready for review August 13, 2025 17:39
@smoogipoo smoogipoo requested a review from Susko3 August 13, 2025 17:39
Copy link
Member

@Susko3 Susko3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not tested, but the External/build.sh code looks sane and the comment is helpful.

@Susko3 Susko3 merged commit 2e68c99 into ppy:master Aug 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDL_mixer->mpg123 external build issue (Actions)
2 participants