[CIR][LoweringPrepare] Wrap cir.va_arg lowered code in a cir.scope
#1768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `cir.va_arg` lowering may introduce an if-else control flow. This breaks the verifier for control flow operations, e.g., `cir.for`, where there can be only one block inside of the `cond` and `step` regions. This PR wraps the lowered code in a `cir.scope` (only if it will lower to the if-else control flow). Added a test for `va_arg` inside for loop condition, the basic pattern is: `for (; va_arg(...););`
clang/lib/CIR/Dialect/Transforms/TargetLowering/Targets/LoweringPrepareX86CXXABI.cpp
Outdated
Show resolved
Hide resolved
bcardosolopes
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cir.va_arglowering may introduce an if-else control flow.This breaks the verifier for control flow operations, e.g.,
cir.for, where there can be only one block inside of thecondandstepregions.This PR wraps the lowered code in a
cir.scope(only if it will lower to the if-else control flow). Added a test for
va_arginside for loop condition, the basic pattern is:for (; va_arg(...););