Skip to content

Conversation

The4codeblocks
Copy link
Contributor

also adds better error handling by displaying every error/warning where applicable

@BuckarooBanzay BuckarooBanzay added the enhancement New feature or request label May 7, 2025
@BuckarooBanzay
Copy link
Member

lgtm so far, but i would rather add a setting to enable jumping into the unexplored map-parts, do you want to do that or should i do it in a follow-up PR?

@The4codeblocks
Copy link
Contributor Author

should i do it in a follow-up PR?

I think so

@The4codeblocks
Copy link
Contributor Author

?

@S-S-X
Copy link
Member

S-S-X commented May 18, 2025

?

@The4codeblocks in case you want it fast then better just add that configuration here with this PR and keep jumping to unexplored areas disabled by default to keep both behavior and max safety.
In case you want it when other people are ready then just wait a moment and it'll get sorted out eventually.

@The4codeblocks
Copy link
Contributor Author

just add that configuration here with this PR and keep jumping to unexplored areas disabled by default to keep both behavior and max safety.

done

@S-S-X
Copy link
Member

S-S-X commented May 18, 2025

Besides config naming comments settings could be moved here:

jumpdrive/init.lua

Lines 2 to 20 in bb66479

jumpdrive = {
config = {
-- allowed radius
max_radius = tonumber(minetest.settings:get("jumpdrive.max_radius")) or 15,
max_area_radius = tonumber(minetest.settings:get("jumpdrive.max_area_radius")) or 25,
-- max volume in nodes ( ((radius*2) + 1) ^ 3 )
max_area_volume = tonumber(minetest.settings:get("jumpdrive.max_area_volume")) or 29791,
-- base storage value
powerstorage = tonumber(minetest.settings:get("jumpdrive.powerstorage")) or 1000000,
-- base technic power requirement
powerrequirement = tonumber(minetest.settings:get("jumpdrive.power_requirement")) or 2500,
},
-- blacklisted nodes
blacklist = {}
}

But don't think that's super important, but if you happen to have a little bit extra time to move stuff.

Should this be tested on actual server (thinking about pandorabox test server)? I bet that could be arranged too and some players might be willing to test it there too.

That said seems simple enough to me to possibly just get merged without extensive testing... and now that there's disabled by default config IMO rate limiters can wait for another PR.

@The4codeblocks
Copy link
Contributor Author

settings could be moved here:
done

Should this be tested on actual server (thinking about pandorabox test server)?
I agree

The4codeblocks and others added 2 commits May 19, 2025 10:05
Co-authored-by: SX <50966843+S-S-X@users.noreply.github.com>
Co-authored-by: SX <50966843+S-S-X@users.noreply.github.com>
Copy link
Member

@S-S-X S-S-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but didn't actually test it.
Should be safe too as it now requires explicit configuration to enable jd mapgen.

@The4codeblocks
Copy link
Contributor Author

hm?

@S-S-X S-S-X merged commit b65f0cc into mt-mods:master Jun 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants