Play count text parts refinements #29280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry meant to post this here: |
its-not-nice
approved these changes
Aug 18, 2025
src/engraving/dom/edit.cpp
Outdated
| @@ -7204,7 +7214,7 @@ void Score::undoAddElement(EngravingItem* element, bool addToLinkedStaves, bool | |||
| nbreath->setTrack(linkedTrack); | |||
| nbreath->setParent(seg); | |||
| doUndoAddElement(nbreath); | |||
| } else if (element->isPlayCountText()) { | |||
| } /*else if (element->isPlayCountText() && staff->shouldShowPlayCount()) { | |||
There was a problem hiding this comment.
Why not just remove this code?
src/engraving/dom/excerpt.cpp
Outdated
| @@ -1024,8 +1024,13 @@ static MeasureBase* cloneMeasure(MeasureBase* mb, Score* score, const Score* osc | |||
| } | |||
| } | |||
|
|
|||
| if (oe && !oe->generated() && !oe->excludeFromOtherParts()) { | |||
| bool cloneBarLine = oe && oe->isBarLine() && toBarLine(oe)->barLineType() == BarLineType::END_REPEAT | |||
| && toBarLine(oseg->element(0))->playCountText(); | |||
There was a problem hiding this comment.
toBarLine(oseg->element(0)) -- can this be null? because you check it for null in other places
miiizen
force-pushed
the
29158-play-cout-parts
branch
2 times, most recently
from
149aea1 to
c0d6f23
Compare
miiizen
force-pushed
the
29158-play-cout-parts
branch
from
c0d6f23 to
00d2be9
Compare
mike-spa
approved these changes
Aug 18, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #29158
Resolves: #29268
Resolves: #29236 & its cause
Resolves: increasing repeat count in parts had no effect in other parts & main score