Remove pointless initialisation of integration step size #3249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clinssen
added
S: Normal
|
@clinssen, could you please provide a description for this PR? |
heplesser
reviewed
Oct 27, 2024
heplesser
requested changes
Oct 27, 2024
There was a problem hiding this comment.
@clinssen I think in this case the code is actually wrong/outdated. We us an adaptive-stepsize solver, so we should not need to control the integration time step manually. See also inline comment. I'd suggest to change the code instead (but check for consequences).
clinssen
force-pushed
the
aeif_timestep_note
branch
3 times, most recently
from
6471863 to
10c3449
Compare
clinssen
changed the title
clinssen
force-pushed
the
aeif_timestep_note
branch
from
10c3449 to
5ae5658
Compare
heplesser
approved these changes
Dec 9, 2024
otcathatsya
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add note about maximum enforced timestep in all aeif models.Remove pointless initialisation of integration step size to max 0.01 ms (see discussion below).