nixos-anywhere: fixes relating to --build-on-remote
#366
Conversation
Fixes nix-community#347 Co-Authored-By: mangoiv <mail@mangoiv.com>
There was a problem hiding this comment.
This is a tricky one IMO - ideally we'd have a flag or even feature detection for certain releases of nix. But the fact that we need different ssh store protocol for different commands complicates that.
I can't claim to have a good, up-to-date overview on the glitches of each of the ssh store protocols per nix/lix release either.
That being said, it looks like a good fix for real-world trouble, so merging for now is fine with me. Might be worth it to add a flag to use ssh-ng again nevertheless, but we can also do so later if needed.
Nit: not too familiar with the terraform module myself, but could that be solved by a subshell or so? Anything that doesn't require us to keep another list of variables consistent?
Due to the Terraform variables being passed to `run-nixos-anywhere.sh` via environment variables, these environment variables wound up getting passed to `nixos-anywhere`. `nixos-anywhere` would then read the value `false` which would break everything as it expects the variable to be unset or set to `y`, leading to `disko_script` not being set.
Enzime
force-pushed
the
fix/build-on-remote
branch
from
9531b59 to
a4cd5ed
Compare
|
I've updated the Terraform code to pass the arguments as one JSON environment variable instead 👍 |
|
Superseded by #383 |
nixos-anywhere: avoid
ssh-ng://withnix copyFixes [bug] nix-copy should not use ssh-ng because a nix bug makes it blow up #347
terraform/install: fix
build_on_remote = false