Skip to content

removing function AnalyzeNACLRules and fix tests #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

removing function AnalyzeNACLRules and fix tests #932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25ab5e2
removing function AnalyzeNACLRules and fix tests
olasaadi99 Nov 27, 2024
3254942
fix
olasaadi99 Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 0 additions & 49 deletions pkg/commonvpc/nacl_analysis.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,55 +252,6 @@ func initConnectivityResult(connectivityMap map[string]*ConnectivityResult, indx
}
}

func getConnStr(src, dst, conn string) string {
return fmt.Sprintf("%s => %s : %s\n", src, dst, conn)
}

// AnalyzeNACLRules todo: this is used only in testing. Did not expand for deny.
func (na *NACLAnalyzer) AnalyzeNACLRules(rules []*NACLRule, subnet *netset.IPBlock,
isIngress bool, subnetDisjointTarget *netset.IPBlock,
) (string, *ConnectivityResult) {
res := []string{}
connResult := &ConnectivityResult{IsIngress: isIngress}
connResult.AllowedConns = map[*netset.IPBlock]*netset.TransportSet{}
connResult.DeniedConns = map[*netset.IPBlock]*netset.TransportSet{}
if subnetDisjointTarget == nil {
connResult = nil
}
if isIngress {
disjointSrcPeers, disjointDstPeers := getDisjointPeersForIngressAnalysis(rules, subnet)
// ingress
for _, src := range disjointSrcPeers {
allowedIngressConns, _, allowRules, _ := GetAllowedXgressConnections(rules, src, subnet, disjointDstPeers, true)
for dst, conn := range allowedIngressConns {
res = append(res, getConnStr(src.ToIPRanges(), dst, common.LongString(conn)))
dstIP, err := netset.IPBlockFromIPRangeStr(dst)
if err == nil && subnetDisjointTarget != nil && subnetDisjointTarget.IsSubset(dstIP) {
connResult.AllowedConns[src] = conn
// the indexing of allowedIngressConns and allowRules are identical
connResult.AllowRules[src] = allowRules[dst]
}
}
}
return strings.Join(res, ""), connResult
}
// egress
disjointSrcPeers, disjointDstPeers := getDisjointPeersForEgressAnalysis(rules, subnet)
for _, dst := range disjointDstPeers {
allowedEgressConns, _, allowRules, _ := GetAllowedXgressConnections(rules, dst, subnet, disjointSrcPeers, false)
for src, conn := range allowedEgressConns {
res = append(res, getConnStr(src, dst.ToIPRanges(), common.LongString(conn)))
srcIP, err := netset.IPBlockFromIPRangeStr(src)
if err == nil && subnetDisjointTarget != nil && subnetDisjointTarget.IsSubset(srcIP) {
connResult.AllowedConns[dst] = conn
// the indexing of allowedEgressConns and allowRules are identical
connResult.AllowRules[dst] = allowRules[src]
}
}
}
return strings.Join(res, ""), connResult
}

// TODO: return a map from each possible subnetDisjointTarget to its ConnectivityResult, instead of a specific ConnectivityResult
// get allowed and denied connections (ingress and egress) for a certain subnet to which this nacl is applied
func (na *NACLAnalyzer) AnalyzeNACL(subnet *netset.IPBlock) (
Expand Down
Loading