removing function AnalyzeNACLRules and fix tests #932
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
this branch is included in #933 |
adisos
approved these changes
Nov 28, 2024
zivnevo
requested changes
Dec 2, 2024
Comment on lines
+320
to
+342
| fmt.Printf("ipBlockString: %v\n", ipBlockString) | ||
| fmt.Printf("connectivityResult.AllowedConns: \n") | ||
| for ipRange, conn := range connectivityResult.AllowedConns { | ||
| fmt.Printf("ipRange.ToIPRanges(): %v\n", ipRange.ToIPRanges()) | ||
| fmt.Printf("conn: %v\n", conn) | ||
| } | ||
|
|
||
| //nolint:all | ||
| /*src := common.FromCidr("1.1.1.1/32") | ||
| dst := common.FromCidr("10.0.0.0/24") | ||
| disjointPeers := []*netset.IPBlock{dst} | ||
| res := commonvpc.GetAllowedXgressConnections(rulesTest1, src, dst, disjointPeers, true) | ||
| for d, c := range res { | ||
| fmt.Printf("%s => %s : %s\n", src.ToIPAdress(), d, c.String()) | ||
| require.True(t, c.Equal(getAllConnSet())) | ||
| }*/ | ||
| fmt.Printf("connectivityResult.AllowRules: \n") | ||
| for ipRange, conn := range connectivityResult.AllowRules { | ||
| fmt.Printf("ipRange.ToIPRanges(): %v\n", ipRange.ToIPRanges()) | ||
| fmt.Printf("conn: %v\n", conn) | ||
| } | ||
| fmt.Printf("connectivityResult.DeniedConns: \n") | ||
| for ipRange, conn := range connectivityResult.DeniedConns { | ||
| fmt.Printf("ipRange.ToIPRanges(): %v\n", ipRange.ToIPRanges()) | ||
| fmt.Printf("conn: %v\n", conn) | ||
| } | ||
|
|
||
| fmt.Printf("done\n") | ||
| fmt.Printf("connectivityResult.DenyRules: \n") | ||
| for ipRange, conn := range connectivityResult.DenyRules { | ||
| fmt.Printf("ipRange.ToIPRanges(): %v\n", ipRange.ToIPRanges()) | ||
| fmt.Printf("conn: %v\n", conn) | ||
| } |
There was a problem hiding this comment.
Do we need all these prints?
We already have huge logs for our tests - it makes it hard to search for failures.
So unless there is a failure, I prefer tests to produce only very little text if at all.
There was a problem hiding this comment.
not needed
removed
zivnevo
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.