WIP. Port DirectAccess feature from Wallet to TestApp. #1201
+1,956
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koukarine
force-pushed
the
directaccess_move
branch
8 times, most recently
from
1357c90 to
c1f4526
Compare
koukarine
force-pushed
the
directaccess_move
branch
from
c1f4526 to
2e70a2b
Compare
koukarine
force-pushed
the
directaccess_move
branch
2 times, most recently
from
cb390b5 to
611e01c
Compare
- Wallet DirectAccess code ported into multipaz.directaccess module. - Refactored to avoid APDU initialization lock up (removed runBlocking calls). - Removed explicit document slot handling in favor of automatic handling as there is only one slot available so far. - Improved APDU calling logic to avoid calls without requesting document slot. Test: All Unit tests are passing (bar KI). Test: Manually tested via samples/testapp on Android and iOS. Signed-off-by: koukarine <koukarine@google.com>
koukarine
force-pushed
the
directaccess_move
branch
from
611e01c to
769570e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test: All Unit tests are passing.
Test: Manually tested via samples/testapp on Android.
Test: Tested with APDU phone powered off and app verifier (FAILED).
Fixes #1036