Skip to content

Added linux s390x Dockerfile #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

abhilash-sivan
Copy link

@abhilash-sivan abhilash-sivan commented Jul 1, 2025

Dockerfile for prebuildify Docker images targeting the s390x architecture

Reference: https://github.com/prebuild/docker-images/blob/master/linux-arm64/Dockerfile

@vweevers
Copy link
Member

vweevers commented Jul 1, 2025

Nice, I didn't know dockcross provided an image for this. That means it's low maintenance for us.

I'll try to review later this week, thanks for the PR!

Copy link
Member

@vweevers vweevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, needs a few tweaks. And can you please add a description to the README? Under ## Images.

@abhilash-sivan
Copy link
Author

And can you please add a description to the README? Under ## Images.

I've added this to the README, but I'm not sure about the correct placement. Please let me know if it needs to be reordered. Thanks

@abhilash-sivan abhilash-sivan requested a review from vweevers July 4, 2025 17:15
@abhilash-sivan
Copy link
Author

Hi @vweevers

Just checking in—could you please review the latest changes and merge them if everything looks good?

@abhilash-sivan
Copy link
Author

Hi @vweevers @ralphtheninja

Could someone please review and merge this? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants