-
Notifications
You must be signed in to change notification settings - Fork 8
Added linux s390x Dockerfile #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Nice, I didn't know dockcross provided an image for this. That means it's low maintenance for us. I'll try to review later this week, thanks for the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, needs a few tweaks. And can you please add a description to the README? Under ## Images
.
Co-authored-by: Vincent Weevers <mail@vincentweevers.nl>
I've added this to the README, but I'm not sure about the correct placement. Please let me know if it needs to be reordered. Thanks |
Hi @vweevers Just checking in—could you please review the latest changes and merge them if everything looks good? |
Could someone please review and merge this? Thanks! |
Dockerfile for prebuildify Docker images targeting the s390x architecture
Reference: https://github.com/prebuild/docker-images/blob/master/linux-arm64/Dockerfile