blockifier: move logic inside felt_size_count

[avivg-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[avivg-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• blockifier: move blake_estimation_consts into struct #8698
• blockifier: move logic inside casm_v2hash_resource_estimate #8694
• blockifier: encode_and_blake into trait #8696
• blockifier: move execution utils logic to casm_estimation #8693
• blockifier: encode blake in trait #8695
• blockifier: move logic inside felt_size_count #8692 👈 (View in Graphite)
• blockifier: move blake constants to felt_size_count #8701
• blockifier: rename blake encoding constants #8731
• blockifier: change input to felt_counts fn count_blake_opcodes #8704
• blockifier: change input to felt_counts fn compute_blake_hash_steps #8702
• main-v0.14.1

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2025-08-19T16:29:52Z
• Started at 2025-08-20T07:34:45Z
• Started at 2025-08-20T07:35:05Z
• Started at 2025-08-20T07:53:00Z
• Started at 2025-08-20T08:12:07Z
• Started at 2025-08-20T08:12:07Z
• Started at 2025-08-20T08:39:42Z
• Started at 2025-08-20T11:16:28Z
• Started at 2025-08-20T12:07:49Z
• Started at 2025-08-20T13:28:45Z
• Started at 2025-08-20T15:00:21Z
• Started at 2025-08-20T15:19:15Z
• Started at 2025-08-20T15:35:35Z

[avivg-starkware]

Reviewable status: 0 of 3 files reviewed, 3 unresolved discussions (waiting on @AvivYossef-starkware and @noaov1)

---

crates/blockifier/src/execution/execution_utils.rs line 409 at r1 (raw file):

/// Calculates the total number of u32s required to encode the given number of big and small felts.
/// Big felts encode to 8 u32s each, small felts encode to 2 u32s each.
fn total_u32s_from_felts(n_big_felts: usize, n_small_felts: usize) -> usize {

Changed the name of the func to this:

Suggestion:

encoded_u32_len

---

crates/blockifier/src/execution/execution_utils.rs line 416 at r1 (raw file):

        .checked_mul(blake_encoding::N_U32S_SMALL_FELT)
        .expect("Overflow computing small felts u32s");
    big_u32s.checked_add(small_u32s).expect("Overflow computing total u32s")

removed checked_add safety
Seems redundant when looking at other places in the code in which arithmetics with n_steps are done (steps > u32 count)

Suggestion:

    let big_u32s = n_big_felts
        .checked_mul(blake_encoding::N_U32S_BIG_FELT)
        .expect("Overflow computing big felts u32s");
    let small_u32s = n_small_felts
        .checked_mul(blake_encoding::N_U32S_SMALL_FELT)
        .expect("Overflow computing small felts u32s");
    big_u32s.checked_add(small_u32s).expect("Overflow computing total u32s"

---

crates/blockifier/src/execution/execution_utils.rs line 459 at r1 (raw file):

/// Returns the number of BLAKE opcodes needed to hash the given felts.
/// Each BLAKE opcode processes 16 u32s (partial messages are padded).
fn count_blake_opcode(n_big_felts: usize, n_small_felts: usize) -> usize {

Changed the name of the func to this:

Suggestion:

blake_opcode_count

[AvivYossef-starkware]

@AvivYossef-starkware reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @noaov1)

---

crates/blockifier/src/execution/contract_class.rs line 89 at r2 (raw file):

    /// Returns the total number of `u32` words required to encode all felts
    /// according to the small/large felt encoding scheme.

Suggestion:

encode_felts_to_u32s func

---

crates/blockifier/src/execution/contract_class.rs line 92 at r2 (raw file):

    pub(crate) fn encoded_u32_len(&self) -> usize {
        self.large * Self::U32_WORDS_PER_LARGE_FELT + self.small * Self::U32_WORDS_PER_SMALL_FELT
    }

plz add test that compare it to the actual encoding

Code quote:

    pub(crate) fn encoded_u32_len(&self) -> usize {
        self.large * Self::U32_WORDS_PER_LARGE_FELT + self.small * Self::U32_WORDS_PER_SMALL_FELT
    }

[avivg-starkware]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @avivg-starkware and @noaov1)

---

crates/blockifier/src/execution/contract_class.rs line 92 at r2 (raw file):

Previously, AvivYossef-starkware wrote…

plz add test that compare it to the actual encoding

Working on it

---

crates/blockifier/src/execution/contract_class.rs line 89 at r2 (raw file):

    /// Returns the total number of `u32` words required to encode all felts
    /// according to the small/large felt encoding scheme.

done

[AvivYossef-starkware]

@AvivYossef-starkware reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @avivg-starkware and @noaov1)

---

crates/blockifier/src/execution/contract_class.rs line 89 at r2 (raw file):

Previously, avivg-starkware wrote…

done

where?

[avivg-starkware]

Reviewable status: 1 of 4 files reviewed, 4 unresolved discussions (waiting on @AvivYossef-starkware and @noaov1)

---

crates/blockifier/src/execution/contract_class.rs line 89 at r2 (raw file):

Previously, AvivYossef-starkware wrote…

where?

sorry, now

---

crates/blockifier/src/execution/contract_class.rs line 92 at r2 (raw file):

Previously, avivg-starkware wrote…

Working on it

added