Skip to content

blockifier: encode blake in trait #8695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: graphite-base/8695
Choose a base branch
from
Open

blockifier: encode blake in trait #8695

wants to merge 1 commit into from

Conversation

avivg-starkware
Copy link
Contributor

No description provided.

This was referenced Aug 19, 2025
Open
Open
@reviewable-StarkWare
Copy link

This change is Reviewable

@avivg-starkware avivg-starkware marked this pull request as ready for review August 19, 2025 17:01
This was referenced Aug 19, 2025
Merged
Open
@avivg-starkware Graphite App
Copy link
Contributor Author

avivg-starkware commented Aug 19, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@avivg-starkware avivg-starkware mentioned this pull request Aug 19, 2025
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 19, 2025 •
edited
Loading

Artifacts upload workflows:

@avivg-starkware avivg-starkware mentioned this pull request Aug 20, 2025
Open
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/encode_and_blake_hash_resources_in_trait branch from 1b8280e to e6c3e18 Compare August 20, 2025 07:34
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/move_logic_to_feltsize branch from 56419e6 to 592d498 Compare August 20, 2025 07:34
This was referenced Aug 20, 2025
Open
Open
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/encode_and_blake_hash_resources_in_trait branch from e6c3e18 to fbdc226 Compare August 20, 2025 07:52
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/move_logic_to_feltsize branch from 592d498 to 889cd06 Compare August 20, 2025 07:52
@avivg-starkware avivg-starkware mentioned this pull request Aug 20, 2025
Open
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/move_logic_to_feltsize branch from 889cd06 to a519a77 Compare August 20, 2025 08:12
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/encode_and_blake_hash_resources_in_trait branch 2 times, most recently from 73a49b2 to c26eb39 Compare August 20, 2025 08:39
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/move_logic_to_feltsize branch 2 times, most recently from 90a20d7 to 7a2291c Compare August 20, 2025 11:16
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/encode_and_blake_hash_resources_in_trait branch from c26eb39 to 6008f4b Compare August 20, 2025 11:16
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/move_logic_to_feltsize branch from 7a2291c to 53418be Compare August 20, 2025 12:07
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/encode_and_blake_hash_resources_in_trait branch from 6008f4b to 35d81db Compare August 20, 2025 12:07
AvivYossef-starkware
AvivYossef-starkware requested changes Aug 20, 2025
View reviewed changes
Copy link
Contributor

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AvivYossef-starkware reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1)

crates/blockifier/src/execution/casm_hash_estimation.rs line 200 at r1 (raw file):

        felt_size_groups: &FeltSizeCount,
    ) -> EstimatedExecutionResources {
        encode_and_blake_hash_resources(felt_size_groups)

why not delete encode_and_blake_hash_resources
and keep only estimated_resources_of_hash_function?

Code quote:

encode_and_blake_hash_resources

avivg-starkware
avivg-starkware commented Aug 20, 2025
View reviewed changes
Copy link
Contributor Author

@avivg-starkware avivg-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @noaov1)

crates/blockifier/src/execution/casm_hash_estimation.rs line 200 at r1 (raw file):

Previously, AvivYossef-starkware wrote…

why not delete encode_and_blake_hash_resources
and keep only estimated_resources_of_hash_function?

Deleted in next PR: #8696

@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/encode_and_blake_hash_resources_in_trait branch from 35d81db to 9af27b6 Compare August 20, 2025 13:28
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/move_logic_to_feltsize branch from 53418be to 6cbb062 Compare August 20, 2025 13:28
@avivg-starkware avivg-starkware force-pushed the avivg/blockifier/encode_and_blake_hash_resources_in_trait branch from 9af27b6 to 6e19b77 Compare August 20, 2025 13:30
AvivYossef-starkware
AvivYossef-starkware approved these changes Aug 20, 2025
View reviewed changes
Copy link
Contributor

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AvivYossef-starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

AvivYossef-starkware
AvivYossef-starkware approved these changes Aug 20, 2025
View reviewed changes
Copy link
Contributor

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

@avivg-starkware avivg-starkware changed the base branch from avivg/blockifier/move_logic_to_feltsize to graphite-base/8695 August 20, 2025 15:18
@avivg-starkware avivg-starkware mentioned this pull request Aug 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AvivYossef-starkware AvivYossef-starkware AvivYossef-starkware approved these changes

@noaov1 noaov1 Awaiting requested review from noaov1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avivg-starkware @reviewable-StarkWare @AvivYossef-starkware