Skip to content

starknet_os: validate_builtins function #8724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main-v0.14.1
Choose a base branch
from
Open

starknet_os: validate_builtins function #8724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion crates/starknet_os/src/runner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ use crate::io::os_input::{
};
use crate::io::os_output::{StarknetAggregatorRunnerOutput, StarknetOsRunnerOutput};
use crate::metrics::OsMetrics;
#[cfg(any(test, feature = "testing"))]
use crate::test_utils::validate_builtins;

pub struct RunnerReturnObject {
#[cfg(feature = "include_program_output")]
Expand Down Expand Up @@ -208,7 +210,7 @@ pub fn run_os_for_testing<S: StateReader>(
}: OsHints,
state_readers: Vec<S>,
) -> Result<(StarknetOsRunnerOutput, Vec<OsTransactionTrace>), StarknetOsError> {
let (runner_output, snos_hint_processor) = create_hint_processor_and_run_os(
let (mut runner_output, snos_hint_processor) = create_hint_processor_and_run_os(
layout,
os_hints_config,
&os_block_inputs,
Expand All @@ -220,6 +222,8 @@ pub fn run_os_for_testing<S: StateReader>(
public_key_y,
)?;

validate_builtins(&mut runner_output.cairo_runner);

let txs_trace: Vec<OsTransactionTrace> =
snos_hint_processor.get_current_execution_helper().unwrap().os_logger.get_txs().clone();

Expand Down
9 changes: 9 additions & 0 deletions crates/starknet_os/src/test_utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,12 @@ pub mod cairo_runner;
pub mod errors;
#[cfg(test)]
pub mod utils;

#[cfg(any(test, feature = "testing"))]
use cairo_vm::vm::runners::cairo_runner::CairoRunner;
pub(crate) fn validate_builtins(runner: &mut CairoRunner) {
let builtins_start = runner.get_builtins_final_stack(runner.vm.get_ap()).unwrap();
let n_builtins = runner.get_program().builtins_len();
let builtins_end = runner.vm.get_ap();
assert_eq!((builtins_start + n_builtins).unwrap(), builtins_end);
}
Loading