starknet_os: validate_builtins function

[Yonatan-Starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[nimrod-starkware]

Please open a py side PR to make sure all python OS related tests pass this validation.

@nimrod-starkware reviewed 1 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, 3 unresolved discussions (waiting on @meship-starkware)

---

crates/starknet_os/src/test_utils.rs line 13 at r1 (raw file):

    let builtins_end = runner.vm.get_ap();
    assert_eq!((builtins_start + n_builtins).unwrap(), builtins_end);
}

Please move this to the utils.rs module.

Code quote:

#[cfg(any(test, feature = "testing"))]
use cairo_vm::vm::runners::cairo_runner::CairoRunner;
pub(crate) fn validate_builtins(runner: &mut CairoRunner) {
    let builtins_start = runner.get_builtins_final_stack(runner.vm.get_ap()).unwrap();
    let n_builtins = runner.get_program().builtins_len();
    let builtins_end = runner.vm.get_ap();
    assert_eq!((builtins_start + n_builtins).unwrap(), builtins_end);
}

---

crates/starknet_os/src/runner.rs line 33 at r1 (raw file):

use crate::metrics::OsMetrics;
#[cfg(any(test, feature = "testing"))]
use crate::test_utils::validate_builtins;

remove and use the full path in the function

---

crates/starknet_os/src/runner.rs line 225 at r1 (raw file):

    )?;

    validate_builtins(&mut runner_output.cairo_runner);

our convention is not to gate imports under feature flags, but use the full path instead

Suggestion:

crate::test_utils::validate_builtins(&mut runner_output.cairo_runner);

[meship-starkware]

@meship-starkware reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Yonatan-Starkware)