Add T3B1 defs, update Ethereum defs #4072
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komret
commented
Jul 31, 2024
tomasklim
reviewed
Jul 31, 2024
Comment on lines
4
to
5
| "eth:BNB:56": false, | ||
| "eth:MATIC:137": false, |
There was a problem hiding this comment.
@matejcik what are those duplicity overrides?
do we still need e.g. misc:BNB, it was removed from fw or not yet?
There was a problem hiding this comment.
@matejcik what are those duplicity overrides?
these allow some internal checks to proceed in case two coins have the same ticker symbol. Some of them could probably be removed now that most defs are external
do we still need e.g.
misc:BNB, it was removed from fw or not yet?
not yet, we still need it
tomasklim
reviewed
Jul 31, 2024
| "is_testnet": true, | ||
| "name": "Ropsten", |
There was a problem hiding this comment.
Ropsten and Rinkeby are both mentioned in sign_tx_eip155.json file. Maybe remove it from tests please 🙏
[no changelog]
Merged
|
will be merged in #4138 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for T3B1.
Updating Ethereum definitions and removing old testnets. This was consulted with @tomasklim.