Skip to content

feat(core): wait for debuglink task before restarting Codec v1 event loop #5577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2025

Conversation

romanz
Copy link
Contributor

@romanz romanz commented Aug 18, 2025

Following #5546, but enabled for Protocol v1 (instead of v2 - which requires more work).

Note: a40fb9f is required to avoid scheduling delay when processing DebugLinkGetState messages, due to loop.race() usage in 106ca13 (which is an implicit assumption of the existing DebugLink loop implementation).

@romanz romanz self-assigned this Aug 18, 2025
@trezor-bot trezor-bot bot added this to Firmware Aug 18, 2025
@github-project-automation github-project-automation bot moved this to 🔎 Needs review in Firmware Aug 18, 2025
Copy link

github-actions bot commented Aug 18, 2025

en main(all)

model device_test click_test persistence_test
T2T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all) test(all) main(all)
Translations

cs main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

de main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

es main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

fr main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

pt main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

Latest CI run: 17110059486

@romanz romanz force-pushed the romanz/wait-debuglink-v1 branch from 973b0ff to 1834365 Compare August 18, 2025 20:57
@romanz romanz changed the base branch from romanz/thp-refactor to main August 18, 2025 20:58
@romanz romanz force-pushed the romanz/wait-debuglink-v1 branch from 1834365 to db91a5b Compare August 19, 2025 05:38
@romanz romanz marked this pull request as ready for review August 19, 2025 06:21
@romanz romanz requested a review from obrusvit as a code owner August 19, 2025 06:21
@romanz romanz requested a review from mmilata August 19, 2025 06:21
# make sure `DebugLinkGetState` won't get stuck
layout_change_box.put(None)

res = await loop.race(_SESSION_TASK, loop.sleep(5000))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Named constant please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romanz

This comment was marked as resolved.

@romanz
Copy link
Contributor Author

romanz commented Aug 20, 2025

Ran device tests on T3T1 @ 24d73c5:

== 1450 passed, 202 skipped, 6 deselected, 12 xfailed in 11178.89s (3:06:18) ===

@romanz
Copy link
Contributor Author

romanz commented Aug 20, 2025

Rebasing over main.

@romanz romanz force-pushed the romanz/wait-debuglink-v1 branch from 24d73c5 to 1c4c379 Compare August 20, 2025 20:15
@romanz romanz added the translations Put this label on a PR to run tests in all languages label Aug 20, 2025
@romanz
Copy link
Contributor Author

romanz commented Aug 20, 2025

Fixing a small UI fixture diff introduced by 79dcd7f.

@romanz romanz force-pushed the romanz/wait-debuglink-v1 branch from 1c4c379 to 946821c Compare August 20, 2025 20:53
@romanz romanz merged commit d9286ea into main Aug 21, 2025
299 of 301 checks passed
@romanz romanz deleted the romanz/wait-debuglink-v1 branch August 21, 2025 07:42
@github-project-automation github-project-automation bot moved this from 🔎 Needs review to 🤝 Needs QA in Firmware Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations Put this label on a PR to run tests in all languages
Projects
Status: 🤝 Needs QA
Development

Successfully merging this pull request may close these issues.

3 participants