-
-
Notifications
You must be signed in to change notification settings - Fork 710
feat(core): wait for debuglink task before restarting Codec v1 event loop #5577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
973b0ff
to
1834365
Compare
1834365
to
db91a5b
Compare
mmilata
reviewed
Aug 19, 2025
core/src/apps/debug/__init__.py
Outdated
# make sure `DebugLinkGetState` won't get stuck | ||
layout_change_box.put(None) | ||
|
||
res = await loop.race(_SESSION_TASK, loop.sleep(5000)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Named constant please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment was marked as resolved.
This comment was marked as resolved.
mmilata
approved these changes
Aug 20, 2025
Ran device tests on T3T1 @ 24d73c5:
|
Rebasing over |
24d73c5
to
1c4c379
Compare
Fixing a small UI fixture diff introduced by 79dcd7f. |
1c4c379
to
946821c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #5546, but enabled for Protocol v1 (instead of v2 - which requires more work).
Note: a40fb9f is required to avoid scheduling delay when processing
DebugLinkGetState
messages, due toloop.race()
usage in 106ca13 (which is an implicit assumption of the existing DebugLink loop implementation).