Skip to content

Reimplement event loop restarts in THP #5546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2025
Merged

Reimplement event loop restarts in THP #5546

merged 3 commits into from
Aug 21, 2025

Conversation

romanz
Copy link
Contributor

@romanz romanz commented Aug 13, 2025

Following #4976, we would like to refactor event loop restart logic:

Slack canvas: https://satoshilabs.slack.com/docs/T0J8V2YBY/F097K1YK2UQ

Rebased over #5548 & #5563 & #5577.

Note to reviewers: GitHub collapses some of the files' diffs (due to their size) - please make sure to expand them :)

@romanz romanz self-assigned this Aug 13, 2025
@trezor-bot trezor-bot bot added this to Firmware Aug 13, 2025
@github-project-automation github-project-automation bot moved this to 🔎 Needs review in Firmware Aug 13, 2025
Copy link

github-actions bot commented Aug 13, 2025

en main(all)

model device_test click_test persistence_test
T2T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all) test(all) main(all)
Translations

cs main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

de main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

es main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

fr main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

pt main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

Latest CI run: 17124191757

@romanz romanz mentioned this pull request Aug 14, 2025
@romanz romanz force-pushed the romanz/thp-refactor branch 2 times, most recently from cb07332 to 6fdbcca Compare August 14, 2025 11:36
@romanz romanz changed the base branch from main to romanz/thp-checksum August 14, 2025 11:50
@romanz romanz force-pushed the romanz/thp-refactor branch from 6fdbcca to 0fa9ce4 Compare August 14, 2025 12:11
@romanz romanz added the translations Put this label on a PR to run tests in all languages label Aug 15, 2025
@romanz romanz force-pushed the romanz/thp-refactor branch from edf6bcb to 83933e5 Compare August 15, 2025 10:22
@romanz romanz changed the base branch from romanz/thp-checksum to main August 15, 2025 10:44
@romanz romanz added translations Put this label on a PR to run tests in all languages and removed translations Put this label on a PR to run tests in all languages labels Aug 15, 2025
@romanz romanz force-pushed the romanz/thp-refactor branch 9 times, most recently from 09a7a02 to c3d79ef Compare August 17, 2025 17:23
@romanz romanz changed the base branch from main to romanz/thp-checksum August 17, 2025 18:02
@romanz romanz marked this pull request as ready for review August 17, 2025 18:05
@romanz romanz requested review from mmilata and M1nd3r August 17, 2025 18:05
Base automatically changed from romanz/thp-sync-responses to main August 19, 2025 05:21
@romanz
Copy link
Contributor Author

romanz commented Aug 19, 2025

Rebasing over main (after #5563 has been merged) and #5577 (for graceful cancellation of DebugLink loop).

@romanz
Copy link
Contributor Author

romanz commented Aug 19, 2025

Tested a local emulator build (from f30b65d) with a recent Suite build:

$ TREZOR_MODEL=T3W1 BITCOIN_ONLY=0 PYOPT=0 QUIET_MODE=1 make -C core build_unix

@romanz
Copy link
Contributor Author

romanz commented Aug 20, 2025

Thanks! Squashing and rebasing over #5577 (will not merge before #5577 (comment) is resolved)

@romanz romanz force-pushed the romanz/thp-refactor branch from f30b65d to efc2848 Compare August 20, 2025 08:04
@romanz romanz changed the base branch from main to romanz/wait-debuglink-v1 August 20, 2025 08:05
@romanz romanz marked this pull request as draft August 20, 2025 08:06
romanz added a commit that referenced this pull request Aug 20, 2025
It has been removed by #5546.

[no changelog]
romanz added a commit that referenced this pull request Aug 20, 2025
It has been removed by #5546.

[no changelog]
romanz added a commit that referenced this pull request Aug 20, 2025
It has been removed by #5546.

[no changelog]
romanz added a commit that referenced this pull request Aug 20, 2025
It has been removed by #5546.

[no changelog]
@romanz romanz force-pushed the romanz/wait-debuglink-v1 branch 2 times, most recently from 1c4c379 to 946821c Compare August 20, 2025 20:53
Base automatically changed from romanz/wait-debuglink-v1 to main August 21, 2025 07:42
@romanz romanz force-pushed the romanz/thp-refactor branch from efc2848 to 6213e3b Compare August 21, 2025 07:50
@romanz romanz force-pushed the romanz/thp-refactor branch from 6213e3b to 5d55e48 Compare August 21, 2025 10:24
@romanz romanz marked this pull request as ready for review August 21, 2025 11:02
@romanz romanz merged commit 5bb49f1 into main Aug 21, 2025
294 of 295 checks passed
@romanz romanz deleted the romanz/thp-refactor branch August 21, 2025 11:46
@github-project-automation github-project-automation bot moved this from 🔎 Needs review to 🤝 Needs QA in Firmware Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations Put this label on a PR to run tests in all languages
Projects
Status: 🤝 Needs QA
Development

Successfully merging this pull request may close these issues.

2 participants