-
-
Notifications
You must be signed in to change notification settings - Fork 710
Reimplement event loop restarts in THP #5546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
cb07332
to
6fdbcca
Compare
6fdbcca
to
0fa9ce4
Compare
edf6bcb
to
83933e5
Compare
09a7a02
to
c3d79ef
Compare
This was referenced Aug 18, 2025
47b0933
to
f30b65d
Compare
Tested a local emulator build (from f30b65d) with a recent Suite build:
|
mmilata
approved these changes
Aug 19, 2025
Thanks! Squashing and rebasing over #5577 (will not merge before #5577 (comment) is resolved) |
f30b65d
to
efc2848
Compare
romanz
added a commit
that referenced
this pull request
Aug 20, 2025
It has been removed by #5546. [no changelog]
romanz
added a commit
that referenced
this pull request
Aug 20, 2025
It has been removed by #5546. [no changelog]
romanz
added a commit
that referenced
this pull request
Aug 20, 2025
It has been removed by #5546. [no changelog]
romanz
added a commit
that referenced
this pull request
Aug 20, 2025
It has been removed by #5546. [no changelog]
1c4c379
to
946821c
Compare
efc2848
to
6213e3b
Compare
6213e3b
to
5d55e48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #4976, we would like to refactor event loop restart logic:
Slack canvas: https://satoshilabs.slack.com/docs/T0J8V2YBY/F097K1YK2UQ
Rebased over #5548 & #5563 & #5577.Note to reviewers: GitHub collapses some of the files' diffs (due to their size) - please make sure to expand them :)