Skip to content

Ignore re-transmitted THP payloads on host #5578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 21, 2025
Merged

Conversation

romanz
Copy link
Contributor

@romanz romanz commented Aug 19, 2025

Host-side changes from #5572 (can be merged into main separately)

@romanz romanz self-assigned this Aug 19, 2025
@trezor-bot trezor-bot bot added this to Firmware Aug 19, 2025
@github-project-automation github-project-automation bot moved this to 🔎 Needs review in Firmware Aug 19, 2025
Copy link

github-actions bot commented Aug 19, 2025

en main(all)

model device_test click_test persistence_test
T2T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all) test(all) main(all)
Translations

cs main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

de main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

es main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

fr main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

pt main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

Latest CI run: 17122163290

@romanz

This comment was marked as outdated.

@romanz romanz added core Trezor Core firmware. Runs on Trezor Model T and Safe models. translations Put this label on a PR to run tests in all languages trezorlib Python library and the command line trezorctl tool. T3W1 and removed core Trezor Core firmware. Runs on Trezor Model T and Safe models. labels Aug 19, 2025
@romanz romanz force-pushed the romanz/thp-ignore-retransmit branch from 5d3dc97 to 7daa2eb Compare August 19, 2025 16:29
@romanz romanz marked this pull request as ready for review August 20, 2025 07:53
@romanz romanz requested a review from matejcik as a code owner August 20, 2025 07:53
@romanz romanz requested review from mmilata and M1nd3r August 20, 2025 07:53
Copy link
Contributor

@M1nd3r M1nd3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have the time to check it all now. I have one nit, otherwise the parts I checked look ok.

@romanz romanz requested a review from obrusvit as a code owner August 20, 2025 18:28
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, does Suite have to implement these changes too?

@romanz
Copy link
Contributor Author

romanz commented Aug 20, 2025

does Suite have to implement these changes too?

I think that Suite probably has implemented it (as part of the ABP algorithm) - right @szymonlesisz?

@romanz romanz force-pushed the romanz/thp-ignore-retransmit branch from 7794f9f to e451adc Compare August 21, 2025 08:57
@romanz romanz merged commit e451adc into main Aug 21, 2025
297 of 298 checks passed
@romanz romanz deleted the romanz/thp-ignore-retransmit branch August 21, 2025 09:55
@github-project-automation github-project-automation bot moved this from 🔎 Needs review to 🤝 Needs QA in Firmware Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T3W1 translations Put this label on a PR to run tests in all languages trezorlib Python library and the command line trezorctl tool.
Projects
Status: 🤝 Needs QA
Development

Successfully merging this pull request may close these issues.

3 participants