CompatHelper: bump compat for Triangulate to 3, (keep existing compat) #2453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ranocha
force-pushed
the
compathelper/new_version/2025-06-24-00-05-28-825-02289089580
branch
from
9b9dde6 to
bc89c95
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2453 +/- ##
==========================================
- Coverage 96.83% 0.00% -96.83%
==========================================
Files 502 502
Lines 41737 41521 -216
==========================================
- Hits 40413 0 -40413
- Misses 1324 41521 +40197
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ranocha
requested changes
Jun 24, 2025
There was a problem hiding this comment.
It still uses an old version in CI, see https://github.com/trixi-framework/Trixi.jl/actions/runs/15837823473/job/44644873208?pr=2453#step:7:365
|
We need to bump the Triangulate.jl compat in StartUpDG.jl (related: jlchan/StartUpDG.jl#198). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
Triangulatepackage from2.2to2.2, 3.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.