Skip to content

ci: dangerfile and storybook brandimage fix #2847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 19, 2025
Merged

ci: dangerfile and storybook brandimage fix #2847

merged 10 commits into from
Mar 19, 2025

Conversation

jpandersen87
Copy link
Contributor

@jpandersen87 jpandersen87 commented Mar 22, 2024 •
edited
Loading

Summary

  • Updates the shouldTest flag in dangerfile so that it will properly be false if PR data isn't present
  • Fixes storybook brandImage url (find uswds.svg relative, not from root)

How To Test

  • dangerfile steps in other workflows besides PR should no longer fail from attempting to run and encountering errors

@jpandersen87
ci: dangerfile fix
29b18a4 
- shouldRun flag updated to properly verify PR exists in addition to bot check
@jpandersen87
Merge branch 'main' into dangerfile
18b68b6
@jpandersen87
bump node 18.x version, update build-and-test
99517ec 
- use latest 18.x node version
- add node 20 to build-and-test matrix
- update action versions in build-and-test
@jpandersen87 jpandersen87 requested a review from a team as a code owner March 22, 2024 20:17
@jpandersen87 jpandersen87 requested a review from a team as a code owner March 22, 2024 20:23
@jpandersen87 jpandersen87 mentioned this pull request Mar 22, 2024
Closed
@werdnanoslen werdnanoslen linked an issue Mar 22, 2024 that may be closed by this pull request
[build] Fix USWDS.svg 404 in storybook #2846
Closed
@jpandersen87 jpandersen87 changed the title ci: dangerfile and build-and-test updated ci: dangerfile fix Mar 13, 2025
@jpandersen87 jpandersen87 changed the title ci: dangerfile fix ci: dangerfile and storybook brandimage fix Mar 13, 2025
@ajfarkas ajfarkas requested a review from lea-m-truss March 19, 2025 20:12
ajfarkas
ajfarkas approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@ajfarkas ajfarkas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we've been working on CI tests today!

@ajfarkas ajfarkas merged commit 408a26f into trussworks:main Mar 19, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lea-m-truss lea-m-truss Awaiting requested review from lea-m-truss

1 more reviewer

@ajfarkas ajfarkas ajfarkas approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[build] Fix USWDS.svg 404 in storybook
2 participants
@jpandersen87 @ajfarkas