Skip to content

ci: dangerfile and storybook brandimage fix #2847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 19, 2025
Merged

ci: dangerfile and storybook brandimage fix #2847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
29b18a4
ci: dangerfile fix
jpandersen87 Mar 22, 2024
18b68b6
Merge branch 'main' into dangerfile
jpandersen87 Mar 22, 2024
99517ec
bump node 18.x version, update build-and-test
jpandersen87 Mar 22, 2024
02037ca
fix sb brandImage url
jpandersen87 Mar 22, 2024
392d9b9
Merge branch 'main' into dangerfile
jpandersen87 Apr 8, 2024
5106314
Merge branch 'main' into dangerfile
jpandersen87 Mar 11, 2025
0c3ade4
merge
jpandersen87 Mar 13, 2025
6d1c53d
Merge branch 'main' into dangerfile
jpandersen87 Mar 13, 2025
bb313e7
Merge branch 'main' into dangerfile
jpandersen87 Mar 14, 2025
e379ba2
Merge branch 'main' into dangerfile
jpandersen87 Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ on:
branches: [ main ]
workflow_dispatch:


jobs:
build-and-test:
runs-on: ubuntu-latest
Expand All @@ -20,10 +19,10 @@ jobs:

steps:
- name: Check out repository
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Set up Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
cache: 'yarn'
Expand All @@ -42,10 +41,10 @@ jobs:

steps:
- name: Check out repository
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Set up Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version-file: '.node-version'
cache: 'yarn'
Expand Down
2 changes: 1 addition & 1 deletion .storybook/USWDS.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { create } from '@storybook/theming/create';
export default create({
brandTitle: 'U.S. Web Design System (USWDS)',
brandUrl: 'https://github.com/trussworks/react-uswds',
brandImage: '/uswds.svg',
brandImage: 'uswds.svg',
brandTarget: '_self',
base: 'light',

Expand Down
5 changes: 3 additions & 2 deletions dangerfile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ import * as child from 'child_process'

import { danger, fail, schedule, warn } from 'danger'

const shouldRun =
!danger.github || (danger.github && danger.github.pr?.user.type !== 'Bot')
// Only run on PRs from non-bots
const shouldRun =
!!danger.github?.pr && danger.github.pr.user.type !== 'Bot'

// Load all modified and new files
const allFiles = (danger.git.modified_files ?? []).concat(
Expand Down