fix(release): Fix import issues post release #3160
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonlenz
changed the title
brandonlenz
commented
May 16, 2025
| @@ -12,8 +12,7 @@ | |||
| "component library" | |||
| ], | |||
| "type": "module", | |||
| "main": "./lib/index.cjs", | |||
| "module": "./lib/index.js", | |||
| "main": "./lib/index.d.ts", | |||
There was a problem hiding this comment.
So @ronaktruss has pointed out that I probably am wrong about this 😅
brandonlenz
commented
May 16, 2025
| @@ -12,8 +12,7 @@ | |||
| "component library" | |||
| ], | |||
| "type": "module", | |||
| "main": "./lib/index.cjs", | |||
| "module": "./lib/index.js", | |||
There was a problem hiding this comment.
Lots of info is pointing to this key being a problem, but there is some documentation about it here:
|
@jpandersen87 have you been successfully using React USWDS > 8.0.0 since the Vite migration? I suspect the project we're seeing issues on might need to update project configs. We're now also seeing: |
|
Looks like the .tgz generated by our package-release job is empty. Does not have a That's likely the issue. Need to verify which |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There seems to be issues for consumers of the library dating back to 8.0.0 (we were able to replicated it as early as this release)
Related Issues or PRs
Attempts to fix: #3159
How To Test
Honestly, not sure. This seems to have been an issue for a little while (since version 8.0.0)
I didn't see this locally pointing to the package on my machine before publish, but not sure that means much.
Might need to release and re-test until we can figure it out
Screenshots (optional)