Skip to content

fix(release): Fix import issues post release #3160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix(release): Fix import issues post release #3160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85b2e6e
Remove pinst, which is no longer needed without husky
brandonlenz May 15, 2025
fe576be
Point to index.d.ts for `main`. Remove "module" property
brandonlenz May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@
"component library"
],
"type": "module",
"main": "./lib/index.cjs",
"module": "./lib/index.js",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of info is pointing to this key being a problem, but there is some documentation about it here:

https://esbuild.github.io/api/#main-fields

"main": "./lib/index.d.ts",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So @ronaktruss has pointed out that I probably am wrong about this 😅

"types": "./lib/index.d.ts",
"exports": {
".": {
Expand Down Expand Up @@ -118,7 +117,6 @@
"happo-plugin-storybook": "^4.4.3",
"happo.io": "^12.1.0",
"jsdom": "^24.0.0",
"pinst": "^3.0.0",
"prettier": "^3.2.5",
"react": "^19.0.0",
"react-dom": "^19.0.0",
Expand Down
10 changes: 0 additions & 10 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2482,7 +2482,6 @@ __metadata:
happo-plugin-storybook: ^4.4.3
happo.io: ^12.1.0
jsdom: ^24.0.0
pinst: ^3.0.0
prettier: ^3.2.5
react: ^19.0.0
react-dom: ^19.0.0
Expand Down Expand Up @@ -8308,15 +8307,6 @@ __metadata:
languageName: node
linkType: hard

"pinst@npm:^3.0.0":
version: 3.0.0
resolution: "pinst@npm:3.0.0"
bin:
pinst: bin.js
checksum: 4ae48a6a60f79c37071233af51b4d91bfc85cfa3c12b66ccda60cdb642b4d14a4ab0cb3587afc55b1f6192cea1772a5e4822026a0d0d3528296edef00cc2d61f
languageName: node
linkType: hard

"pkg-types@npm:^1.3.0":
version: 1.3.1
resolution: "pkg-types@npm:1.3.1"
Expand Down
Loading