Introduce UX guidelines documentation #311
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmcgruer
force-pushed
the
smcgruer-nonnormativeUXGuidelines
branch
from
a6c7888 to
777d29f
Compare
stephenmcgruer
changed the title
stephenmcgruer
force-pushed
the
smcgruer-nonnormativeUXGuidelines
branch
2 times, most recently
from
5f3bd63 to
9dce038
Compare
stephenmcgruer
force-pushed
the
smcgruer-nonnormativeUXGuidelines
branch
from
9dce038 to
e0be04f
Compare
ianbjacobs
reviewed
Aug 11, 2025
ux-guidelines.md
Outdated
Comment on lines
24
to
25
| The payee information fields are intended to communicate to the user who will | ||
| be the recipient of the funds. In most cases this would be the merchant (or |
There was a problem hiding this comment.
Suggested change
| The payee information fields are intended to communicate to the user who will | |
| be the recipient of the funds. In most cases this would be the merchant (or | |
| The payee information fields are intended to communicate to the user: who will | |
| be the recipient of the funds. In most cases this would be the merchant (or |
There was a problem hiding this comment.
I was hoping to avoid grammatical ambiguity. You can read "the user who will be the recipient of the funds" to mean the user is the recipient. If there were a comma after "user" that would be the definitive meaning, but there's no comma and so that's not the meaning. Except it sounds that way kind of also when you read it. :) So I thought maybe a colon could help. I used the same "trick" throughout.
There was a problem hiding this comment.
Ah I see! I have tried to reword it to avoid that, what do you think?
Great catch, fixed! |
ianbjacobs
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #309