Skip to content

Fix Static check in Gaussian likelihood #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2024
Merged

Fix Static check in Gaussian likelihood #484

merged 2 commits into from
Nov 1, 2024

Conversation

stefanocortinovis
Copy link
Contributor

@stefanocortinovis stefanocortinovis commented Nov 1, 2024 •
edited
Loading

Checklist

  • [ x ] I've formatted the new code by running hatch run dev:format before committing.
  • [ NA ] I've added tests for new code.
  • [ NA ] I've added docstrings for the new code.

Description

Previously, a Static object passed as the obs_stddev argument to the Gaussian likelihood would be wrapped in PositiveReal because isinstance(Static, Parameter) evaluates to False. This was affecting examples intro_to_kernels.py and bayesian_optimisation.py. This PR fixes it.

Issue Number: N/A

@thomaspinder thomaspinder merged commit 0816901 into JaxGaussianProcesses:main Nov 1, 2024
11 checks passed
@stefanocortinovis stefanocortinovis deleted the fix_static_check branch November 1, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaspinder thomaspinder thomaspinder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanocortinovis @thomaspinder