Skip to content

Fix Static check in Gaussian likelihood #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Fix Static check in Gaussian likelihood #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
561c57f
Fix passing Static obs_stddev to Gaussian likelihood
stefanocortinovis Nov 1, 2024
212673f
Fix intro_to_kernels.py example
stefanocortinovis Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/intro_to_kernels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ def forrester(x: Float[Array, "N"]) -> Float[Array, "N"]: # noqa: F821
prior = gpx.gps.Prior(mean_function=mean, kernel=kernel)

likelihood = gpx.likelihoods.Gaussian(
num_datapoints=D.n, obs_stddev=PositiveReal(value=jnp.array(1e-3), tag="Static")
num_datapoints=D.n, obs_stdev=Static(jnp.array(1e-3))
) # Our function is noise-free, so we set the observation noise's standard deviation to a very small value

no_opt_posterior = prior * likelihood
Expand Down
8 changes: 3 additions & 5 deletions gpjax/likelihoods.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
GHQuadratureIntegrator,
)
from gpjax.parameters import (
Parameter,
PositiveReal,
Static,
)
Expand Down Expand Up @@ -152,10 +151,9 @@ def __init__(
likelihoods. Must be an instance of `AbstractIntegrator`. For the Gaussian likelihood, this defaults to
the `AnalyticalGaussianIntegrator`, as the expected log likelihood can be computed analytically.
"""
if isinstance(obs_stddev, Parameter):
self.obs_stddev = obs_stddev
else:
self.obs_stddev = PositiveReal(jnp.asarray(obs_stddev))
if not isinstance(obs_stddev, (PositiveReal, Static)):
obs_stddev = PositiveReal(jnp.asarray(obs_stddev))
self.obs_stddev = obs_stddev

super().__init__(num_datapoints, integrator)

Expand Down
Loading