-
Notifications
You must be signed in to change notification settings - Fork 64
Add patch to specific cola version to support jax>0.5.0 #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into GPJax!
If you have not heard from us in a while, please feel free to ping @gpjax/developers
or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on Slack for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
A few unit tests are failing with |
Can you try rebasing from #498 and see if this fixes the issues please? |
Oops, my unpin of JAX might be an overreach (see discussions about optax vs jaxopt) - should I limit this PR to just pinning cola? |
Yes, let's restrict this just to cola right now. Once we've removed jaxopt as a dependency, then I think we're good to remove the JAX pin and release a new version :) |
Rebased and reduced to only pinning cola. 7 tests fail with Combining the cola pin with unpinning jax, jaxlib, and flax (required to match unpinned jax version) gives 100% test success. |
JFYI I noticed there was a new release of Cola yesterday, so we can pin to that now instead of the specific commit. |
Thanks for the effort here, but I'm closing as the issue is resolve in the latest release. |
Checklist
Changes only to pyproject.toml, so these do not apply
hatch run dev:format
before committing.Description
Issue Number: #490