Fix jaxtyping and flax issues in tests #498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaspinder
approved these changes
Mar 25, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
hatch run dev:formatbefore committing.Description
The diff is large thanks to the automatic ruff fixes when running
hatch run dev:all-tests; review commit-by-commit. The first commit is a remix of #437. The second commit is a little suspicious, but theStates are small enough for it to be reasonable. A proper solution might implement__eq__ingpjax.parameters.Parameterto compare value and metadata for variables, but I thought this was overkill for a single test (also I don't know the flax api that well).Related to #490, #497.