♻️ (sync-server) align dependency versions; cleanup lint & typecheck #4605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged No assets were unchanged |
MatissJanis
changed the title
WalkthroughThe changes update multiple dependency versions across various package configurations and source files. Several package.json files (root, api, crdt, desktop-client, desktop-electron, sync-server, and loot-core) now reference newer versions of tools such as TypeScript, ESLint, Jest, and related type definitions. In the sync-server package, some script commands (e.g., lint, lint:fix, types, verify) have been removed while dependency versions have been bumped. Additionally, a new Jest environment dependency has been added to the loot-core package. In the desktop-client code, the Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (7)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
matt-fidd
reviewed
Mar 11, 2025
| @@ -61,7 +61,7 @@ export const PILL_STYLE = { | |||
| }; | |||
|
|
|||
| export function getColumnWidth({ | |||
| show3Cols, | |||
| show3Cols = true, | |||
There was a problem hiding this comment.
Unless I'm missing something, doesn't this change the default behaviour from falsy to true?
There was a problem hiding this comment.
Good spot! Updated it here: cd7538e
MikesGlitch
previously approved these changes
Mar 11, 2025
matt-fidd
changed the title
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few small changes here:
sync-server(i.e. only a single typescript version should be used in the project instead of two different, etc.)sync-serversince we run those globally for all packages