♻️ bump sync-server dependencies #5497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
matt-fidd
changed the title
WalkthroughThis change updates dependency versions across several package.json files in multiple packages. The main updates include bumping the versions of Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (7)
🧰 Additional context used📓 Path-based instructions (1)**/*.{ts,tsx}📄 CodeRabbit Inference Engine (.cursor/rules/typescript.mdc)
Files:
🧠 Learnings (27)📓 Common learnings📚 Learning: typescript configuration and entry points for the @actual-app/components package will be added when ...Applied to files:
📚 Learning: in the actual budget project, avoid suggesting documentation of typescript version requirements for ...Applied to files:
📚 Learning: jest testing framework is used in multiple packages (api, crdt, loot-core) while desktop-client uses...Applied to files:
📚 Learning: in `packages/loot-core/src/types/util.d.ts`, `transobjectliteral` remains typed as `any` due to the ...Applied to files:
📚 Learning: applies to **/*.{ts,tsx} : use typescript for all code; prefer interfaces over types....Applied to files:
📚 Learning: the project follows an incremental approach to typescript strict mode migration. during the conversi...Applied to files:
📚 Learning: in the `desktop-electron` module, `loot-core`'s essential files are intentionally copied during pack...Applied to files:
📚 Learning: in `packages/desktop-electron/index.ts`, `process.env.lootcorescript` is correctly assigned a string...Applied to files:
📚 Learning: applies to **/*.{ts,tsx} : avoid using `any` or `unknown` unless absolutely necessary. look for type...Applied to files:
📚 Learning: applies to **/*.{ts,tsx} : avoid type assertions with `as` or `!`; prefer using `satisfies`....Applied to files:
📚 Learning: write concise, technical typescript code....Applied to files:
📚 Learning: applies to **/*.{ts,tsx} : favor named exports for components and utilities....Applied to files:
📚 Learning: query results in `packages/loot-core/src/platform/client/fetch/index.d.ts` are intentionally typed a...Applied to files:
📚 Learning: when duplicating a budget in `packages/loot-core/src/server/main.ts`, `fs.copyfile` can be used to c...Applied to files:
📚 Learning: the file `packages/loot-core/src/shared/rules.ts` is not yet translated, so internationalization usi...Applied to files:
📚 Learning: in `packages/loot-core/src/server/backups.web.ts`, during backup creation, only the `.latest.` backu...Applied to files:
📚 Learning: in `packages/loot-core/src/types/models/bank-sync.d.ts`, when defining typescript types for data rec...Applied to files:
📚 Learning: in the schema definitions in `packages/loot-core/src/server/aql/schema/index.ts`, field definitions ...Applied to files:
📚 Learning: in `packages/loot-core/src/server/accounts/transaction-rules.ts`, the `stage` property can have lega...Applied to files:
📚 Learning: in this repository we use minimatch v10, which provides the matcher as a named export; the correct i...Applied to files:
📚 Learning: in `packages/loot-core/src/platform/server/fs/index.web.ts`, errors are already handled in other loc...Applied to files:
📚 Learning: in `packages/loot-core/src/server/backups.web.ts`, developers prefer to keep the error handling for ...Applied to files:
📚 Learning: in `packages/loot-core/src/platform/server/fs/index.web.ts`, the `getmodifiedtime` function is not u...Applied to files:
📚 Learning: in `packages/loot-core/src/server/main.ts`, when handling errors, the error properties `error_code` ...Applied to files:
📚 Learning: in `packages/loot-core/src/server/accounts/rules.test.ts`, prefer explicit action definitions over r...Applied to files:
📚 Learning: in `packages/loot-core/src/client/actions/account.ts`, within the `syncaccounts` function, the batch...Applied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (15)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
jfdoming
approved these changes
Aug 6, 2025
This was referenced Aug 6, 2025
Johnn27
pushed a commit
to Johnn27/actual
that referenced
this pull request
Aug 12, 2025
* bcrypt 5.0.2 -> 6.0.0 * supertest 6.3.4 -> 7.1.4 * pluggy-sdk 0.70.1 -> 0.74.0 * types * better-sqlite3 11.10.0 -> 12.2.0 * express-rate-limit 7.5.0 -> 8.0.1 * babel/core 7.27.1 -> 7.28.0 * typescript 5.8.3 -> 5.9.2 * node types * note * typechecker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to work my way through these again, it's amazing how fast they fall out of date. Package by package this time instead of upgrade level, it's just easier to test and work through.
The major versions here are all just dropping Node 18 which is fine now we've moved to 20.
Only openid-client left to upgrade here, but v6 is a complete API rewrite so it's one for another PR/time.