Skip to content

Fixes #5228 - has tag(s) filter now takes values when pressing Enter #5263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2025
Merged

Fixes #5228 - has tag(s) filter now takes values when pressing Enter #5263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
244a836
Fixes #5228 - has tag(s) filter now takes values when typing quickly …
Jun 30, 2025
77f510e
Added release notes
Jun 30, 2025
81bf90e
State of GenericInput now gets updated with every keystroke
Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions packages/desktop-client/src/components/util/GenericInput.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,9 @@ export function GenericInput({
return (
<Input
ref={ref}
defaultValue={value || ''}
value={value || ''}
placeholder={t('nothing')}
onEnter={onChange}
onUpdate={onChange}
onChangeValue={onChange}
/>
);
}
Expand Down Expand Up @@ -190,10 +189,9 @@ export function GenericInput({
content = (
<Input
ref={ref}
defaultValue={value || ''}
value={value || ''}
placeholder={getMonthYearFormat(dateFormat).toLowerCase()}
onEnter={onChange}
onUpdate={onChange}
onChangeValue={onChange}
/>
);
break;
Expand All @@ -202,10 +200,9 @@ export function GenericInput({
content = (
<Input
ref={ref}
defaultValue={value || ''}
value={value || ''}
placeholder="yyyy"
onEnter={onChange}
onUpdate={onChange}
onChangeValue={onChange}
/>
);
break;
Expand Down Expand Up @@ -262,10 +259,9 @@ export function GenericInput({
content = (
<Input
ref={ref}
defaultValue={value || ''}
value={value || ''}
placeholder={t('nothing')}
onEnter={onChange}
onUpdate={onChange}
onChangeValue={onChange}
/>
);
}
Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/5263.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Bugfix
authors: [seabeeberry]
---

Fix bug where "has tag(s)" filter created empty tag when using Enter key
Loading