Fixes #5228 - has tag(s) filter now takes values when pressing Enter #5263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing quickly and pressing Enter
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
seabeeberry
changed the title
seabeeberry
changed the title
WalkthroughThe changes update the usage of the Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (2)📓 Common learningspackages/desktop-client/src/components/util/GenericInput.jsx (13)🧬 Code Graph Analysis (1)packages/desktop-client/src/components/util/GenericInput.jsx (1)
🔇 Additional comments (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
seabeeberry
changed the title
|
I think this fix works around the issue instead of addressing the underlying issue in the Input.tsx component itself. Would you consider adding the onChangeValue={onChange} inside the GenericInput? That way the state gets updated directly with each key stroke. |
You are right! I changed it now within GenericInput.jsx. Was I correct to change it for every possible Input component? Sorry, this is my first contribution to a project. |
seabeeberry
changed the title
1 task
youngcw
approved these changes
Jul 3, 2025
passabilities
added a commit
to passabilities/actual-budget
that referenced
this pull request
Jul 8, 2025
…raph * actual/master: (113 commits) Customize tags colors (actualbudget#5032) Run rules on transactions created by a transfer. (actualbudget#5279) add notes to scheduled transactions table (actualbudget#5290) 💬 Added Discord link to the help menu for discoverability (actualbudget#5286) Fixes actualbudget#5278: Applied PrivacyFilter to balance graph display (and added conditionality whether user is hovering on the graph) (actualbudget#5281) add some basic linting rules for translation consistency (actualbudget#5212) Update contributor points calculation logic (actualbudget#5169) feat(currency): add currency setting and format (actualbudget#5167) Move remaining `.d.ts` files to `.ts` (actualbudget#5208) use correct running balance when adding a new transaction (actualbudget#5207) Fix rule templating on date causing crash (actualbudget#5259) Fixes actualbudget#5228 - has tag(s) filter now takes values when pressing Enter (actualbudget#5263) correctly ignore hidden categories when using "Set Average Budget" (actualbudget#5239) Mobile running balance (actualbudget#5219) 🔖 (25.7.1) (actualbudget#5272) fix (actualbudget#5270) 🔖 (25.7.0) (actualbudget#5260) Fixes actualbudget#5238 last synced button text not visible on light theme. (actualbudget#5241) fix: Tracking budget income budget fields missing in mobile view (actualbudget#5251) Fix switching budget type requiring hard reload to take effect (actualbudget#5253) ...
passabilities
added a commit
to passabilities/actual-budget
that referenced
this pull request
Jul 9, 2025
…raph * actual/master: (120 commits) [Goals] limits for remainders (actualbudget#5301) Reword the overspending banner for tracking budget. (actualbudget#5307) Fix a few typos mentioned on Weblate (actualbudget#5211) no hidden (actualbudget#5305) [Goals] upgrade week template to be a periodic template (actualbudget#5295) [Goals] Round template amounts if hide decimals is set (actualbudget#5288)Fix early server-started signification message (actualbudget#5303) Customize tags colors (actualbudget#5032) Run rules on transactions created by a transfer. (actualbudget#5279) add notes to scheduled transactions table (actualbudget#5290) 💬 Added Discord link to the help menu for discoverability (actualbudget#5286) Fixes actualbudget#5278: Applied PrivacyFilter to balance graph display (and added conditionality whether user is hovering on the graph) (actualbudget#5281) add some basic linting rules for translation consistency (actualbudget#5212) Update contributor points calculation logic (actualbudget#5169) feat(currency): add currency setting and format (actualbudget#5167) Move remaining `.d.ts` files to `.ts` (actualbudget#5208) use correct running balance when adding a new transaction (actualbudget#5207) Fix rule templating on date causing crash (actualbudget#5259) Fixes actualbudget#5228 - has tag(s) filter now takes values when pressing Enter (actualbudget#5263) correctly ignore hidden categories when using "Set Average Budget" (actualbudget#5239) ...
This was referenced Aug 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When quickly typing into the filter input and pressing Enter, the entered value was not always correctly applied. Sometimes it resulted in an empty filter being created. In my test it ocurred for other types of filters as well, not only for "has tag(s)".
Updated the GenericInput component to add onChangeValue={onChange}, as suggested by @mauschil. Changed the defaultValue to value.
Now, however quickly you type a filter name and press Enter, your inputted value is correctly applied.