Fix early server-started signification message #5303

MikesGlitch · 2025-07-07T22:14:56Z

This was causing some flakey behaviour if you were on a slow PC and starting/stopping the server. If the server was slow to finish the listen, it would cause a network error when starting the server.

It's not a very common task which is probably why it hasn't been reported as a bug yet.

packages/desktop-client/src/components/manager/ConfigServer.tsx

netlify · 2025-07-07T22:15:55Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`169bd8a`
🔍 Latest deploy log	https://app.netlify.com/projects/actualbudget/deploys/686c4b0df8c3190008701f26
😎 Deploy Preview	https://deploy-preview-5303.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2025-07-07T22:16:26Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
19	10.37 MB → 10.37 MB (+72 B)	+0.00%

Changeset

File	Δ	Size
`src/components/manager/ConfigServer.tsx`	📈 +72 B (+0.39%)	18.23 kB → 18.3 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/index.js	7.86 MB → 7.86 MB (+72 B)	+0.00%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/de.js	134.73 kB	0%
static/js/en-GB.js	6.38 kB	0%
static/js/en.js	124.06 kB	0%
static/js/es.js	70.83 kB	0%
static/js/fr.js	133.74 kB	0%
static/js/nl.js	100.58 kB	0%
static/js/pt-BR.js	124.83 kB	0%
static/js/sv.js	65.13 kB	0%
static/js/th.js	190.63 kB	0%
static/js/uk.js	121.11 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	12.94 kB	0%
static/js/workbox-window.prod.es5.js	5.64 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/ReportRouter.js	820.23 kB	0%
static/js/narrow.js	393.63 kB	0%
static/js/wide.js	115.17 kB	0%
static/js/TransactionList.js	10.92 kB	0%

github-actions · 2025-07-07T22:16:27Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	2.26 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	2.26 MB	0%

packages/sync-server/src/app.ts

coderabbitai · 2025-07-07T22:25:03Z

"""

Walkthrough

This change introduces a guard clause in the onConfigureSyncServer function within the ElectronServerConfig component to prevent multiple concurrent executions by checking the startingSyncServer flag. The UI buttons for starting or saving the sync server configuration are updated to use ButtonWithLoading instead of Button, with the loading state prop renamed from isPending to isLoading. In the sync server code, a new helper function sendServerStartedMessage centralizes the logic for notifying when the server starts and logging the listening address, replacing direct calls in the run function.

Possibly related PRs

Server config ui #4870: Refines the internal logic and UI of the ElectronServerConfig component, which is directly built upon by the changes in this PR.

Suggested labels

:sparkles: merged

Suggested reviewers

youngcw
"""

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 029ec3e and 169bd8a.

⛔ Files ignored due to path filters (1)

upcoming-release-notes/5303.md is excluded by !**/*.md

📒 Files selected for processing (2)

packages/desktop-client/src/components/manager/ConfigServer.tsx (2 hunks)
packages/sync-server/src/app.ts (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

packages/desktop-client/src/components/manager/ConfigServer.tsx
packages/sync-server/src/app.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)

GitHub Check: build (ubuntu-latest)
GitHub Check: build (macos-latest)
GitHub Check: build (windows-latest)
GitHub Check: test
GitHub Check: Wait for Netlify build to finish
GitHub Check: Functional Desktop App
GitHub Check: Analyze
GitHub Check: Build Docker image (alpine)
GitHub Check: Build Docker image (ubuntu)
GitHub Check: compare

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…s not finished listening

…raph * actual/master: (120 commits) [Goals] limits for remainders (actualbudget#5301) Reword the overspending banner for tracking budget. (actualbudget#5307) Fix a few typos mentioned on Weblate (actualbudget#5211) no hidden (actualbudget#5305) [Goals] upgrade week template to be a periodic template (actualbudget#5295) [Goals] Round template amounts if hide decimals is set (actualbudget#5288)

Fix early server-started signification message (actualbudget#5303) Customize tags colors (actualbudget#5032) Run rules on transactions created by a transfer. (actualbudget#5279) add notes to scheduled transactions table (actualbudget#5290) 💬 Added Discord link to the help menu for discoverability (actualbudget#5286) Fixes actualbudget#5278: Applied PrivacyFilter to balance graph display (and added conditionality whether user is hovering on the graph) (actualbudget#5281) add some basic linting rules for translation consistency (actualbudget#5212) Update contributor points calculation logic (actualbudget#5169) feat(currency): add currency setting and format (actualbudget#5167) Move remaining `.d.ts` files to `.ts` (actualbudget#5208) use correct running balance when adding a new transaction (actualbudget#5207) Fix rule templating on date causing crash (actualbudget#5259) Fixes actualbudget#5228 - has tag(s) filter now takes values when pressing Enter (actualbudget#5263) correctly ignore hidden categories when using "Set Average Budget" (actualbudget#5239) ...

* fix issue where server was telling parent process it was ready but was not finished listening * release notes

actual-github-bot bot added the 🚧 WIP label Jul 7, 2025

MikesGlitch commented Jul 7, 2025

View reviewed changes

packages/desktop-client/src/components/manager/ConfigServer.tsx Show resolved Hide resolved

MikesGlitch commented Jul 7, 2025

View reviewed changes

packages/sync-server/src/app.ts Show resolved Hide resolved

MikesGlitch marked this pull request as ready for review July 7, 2025 22:22

actual-github-bot bot added 🔍 ready for review and removed 🚧 WIP labels Jul 7, 2025

MikesGlitch added 2 commits July 7, 2025 22:32

fix issue where server was telling parent process it was ready but wa…

1e0fc5c

…s not finished listening

release notes

169bd8a

MikesGlitch force-pushed the fix/server-notifying-too-early branch from 029ec3e to 169bd8a Compare July 7, 2025 22:32

matt-fidd approved these changes Jul 8, 2025

View reviewed changes

actual-github-bot bot added ✅ approved and removed 🔍 ready for review labels Jul 8, 2025

MikesGlitch merged commit 3a09d91 into actualbudget:master Jul 8, 2025
26 checks passed

actual-github-bot bot added ✨ merged and removed ✅ approved labels Jul 8, 2025

MikesGlitch added this to Icebox Jul 8, 2025

MikesGlitch moved this to Done in Icebox Jul 8, 2025

This was referenced Aug 2, 2025

🐛 Paginate the count points list files call #5448

Merged

🐛 Fix count of release owner points #5451

Closed

Johnn27 pushed a commit to Johnn27/actual that referenced this pull request Aug 12, 2025

Fix early server-started signification message (actualbudget#5303)

aaa12b1

* fix issue where server was telling parent process it was ready but was not finished listening * release notes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix early server-started signification message #5303

Fix early server-started signification message #5303

Uh oh!

MikesGlitch commented Jul 7, 2025 •

edited

Loading

Uh oh!

Uh oh!

netlify bot commented Jul 7, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 7, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 7, 2025 •

edited

Loading

Uh oh!

Uh oh!

coderabbitai bot commented Jul 7, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Fix early server-started signification message #5303

Fix early server-started signification message #5303

Uh oh!

Conversation

MikesGlitch commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for actualbudget ready!

Uh oh!

github-actions bot commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Stats — desktop-client

Uh oh!

github-actions bot commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Stats — loot-core

Uh oh!

Uh oh!

coderabbitai bot commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

MikesGlitch commented Jul 7, 2025 •

edited

Loading

netlify bot commented Jul 7, 2025 •

edited

Loading

github-actions bot commented Jul 7, 2025 •

edited

Loading

github-actions bot commented Jul 7, 2025 •

edited

Loading

coderabbitai bot commented Jul 7, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)